Added new tests to improve test coverage for Neo4jVector #17
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
willtai
commented
Nov 29, 2024
| @@ -345,8 +345,6 @@ def _handle_field_filter( | |||
| query_snippet = f"toLower(n.`{field}`) CONTAINS $param_{param_number}" | |||
| query_param = {f"param_{param_number}": filter_value.rstrip("%")} | |||
| return (query_snippet, query_param) | |||
| else: | |||
| raise NotImplementedError() | |||
There was a problem hiding this comment.
This block is redundant
willtai
force-pushed
the
improve-test-coverage-for-neo4jvector
branch
from
766d771 to
f8a1aec
Compare
willtai
force-pushed
the
improve-test-coverage-for-neo4jvector
branch
from
f8a1aec to
a4587fd
Compare
willtai
force-pushed
the
improve-test-coverage-for-neo4jvector
branch
from
a4587fd to
6f63396
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR improves test coverage for
neo4j_vector.pyfrom 84% to 97%.For the unit tests, a fixture
neo4j_vector_factorywas added to avoid repeated code when setting up unit tests.Type of Change
Complexity
Medium
How Has This Been Tested?
Checklist