-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add About Page with Reusable Components #1
Open
demilade111
wants to merge
11
commits into
langaracpsc:main
Choose a base branch
from
demilade111:about-feature
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Implemented AboutHero for the main About page header - Created MissionSection to highlight the club's mission - Developed ValuesSection to showcase the club's core values - Added ExecutiveDialog for displaying executive details - Built ExecutiveMemberList and ExecutiveMemberProfileCard for displaying executive profiles
- Moved static mission and values data to aboutUsData.ts - Added Executive type definition in member.ts for consistent type usage
- Implemented fetchExecutives to load executive data on first visit - Added validateExecutives to check for backend updates - Enabled persistence using zustand middleware
- Built About page structure using reusable components - Integrated executive data fetch logic from executiveStore - Organized sections: Hero, Mission, Values, and Executives
- Added environment variables for API base URL in .env - Updated tsconfig paths for cleaner imports - Added global gradient styles in index.css for consistent About page theming
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
This PR introduces the About page, featuring reusable components to enhance consistency across the application. The key additions include:
Additionally, the following updates were made:
executiveStore
using Zustand for managing executive data with persistence.App.tsx
to include routing for the new About page.index.css
for consistent theming on the About page..env
for API base URL management.VITE_BASE_URL=''