terraformer planet field bonus logic #412
Open
+52
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lanedirt
requested changes
Oct 24, 2024
There was a problem hiding this comment.
Hi @jackbayliss,
Changes look good to me! I just have a few small whiteline nitpicks to make it a little bit cleaner and conform to the rest of the codebase. Could you take a look at these?
Other than these minor style tweaks, functionality looks to be working great. Thanks for your work on this! 🚀
|
@lanedirt Should hopefully now be sorted, did spot a previous test I did where I missed a whitespace after the closing brace, so sorted that too. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should handle #392
Also adds a variety of tests - feel free to let me know any adjustments.