Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement server settings popup logic #303

Merged
merged 2 commits into from
Aug 23, 2024

Conversation

Jbaukens
Copy link
Contributor

@Jbaukens Jbaukens commented Aug 23, 2024

Merge Request: Server Settings Popup

Overview:

This merge request introduces updates for showing the server settings popup:

  • Server Settings Popup Update:
    Implemented server settings popup.

  • Server Settings Admin View Update:
    Updated the admin settings view to reflect the new options.

Testing:

  • Verified the changes work as expected and the UI is consistent.

Next Steps:

  • Update/create stories to use the new server settings.
  • Code review and merge upon approval.

Note:

  • Additional changes might be added based on further feedback or testing.

Related Issue:

@Jbaukens
Copy link
Contributor Author

Jbaukens commented Aug 23, 2024

Hi @lanedirt.

I opted for the enum fields. I have considered both options and i personally like the project as it try to stay relevant compared to OGame.

I do understand its less permissive as options as it offer less choices, but i do aswell think that if it doesnt meet someones needs, that the fork feature is made for this.

We can for sure later think about a dynamic fields (enums, free fields with an custom setting or other)

Feel free to share your thoughs

NB: Even if the admin settings are restricted access page, i really think it should need validation aswell

Cheers

@lanedirt
Copy link
Owner

Hi @Jbaukens,

The changes look good to me! Also just tested the functionality on my local environment and works great. Great work! 🚀

I agree with the form validation part, that would be a nice thing to add. Feel free to create an issue for that with a short proposal so it can be discussed / looked at in the future.

@lanedirt lanedirt merged commit 724c710 into lanedirt:main Aug 23, 2024
6 checks passed
@Jbaukens Jbaukens deleted the feature/server-settings-popup branch August 23, 2024 20:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add server settings popup
2 participants