Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add server settings popup #169

Closed
lanedirt opened this issue May 19, 2024 · 4 comments · Fixed by #303
Closed

Add server settings popup #169

lanedirt opened this issue May 19, 2024 · 4 comments · Fixed by #303
Assignees
Labels
enhancement New feature or request

Comments

@lanedirt
Copy link
Owner

lanedirt commented May 19, 2024

Add server settings popup which displays actual server settings. A link should be added in the footer.

The SettingService class can be used to retrieve dynamic settings from the database. Note: not all dynamic settings are available yet. See /admin/server-settings page for settings that are defined at this moment.

Example:

Screenshot 2024-05-19 at 11 01 50
Screenshot 2024-05-19 at 11 00 52
@lanedirt lanedirt added the enhancement New feature or request label May 19, 2024
@Jbaukens
Copy link
Contributor

Hi,

I started to progress on that one. Taking small story's for the moment still discovering the code while i try to to make it work with my android application

Cheers

@lanedirt
Copy link
Owner Author

Sounds good 👍 , I'll assign the issue to you. Thanks!

@Jbaukens
Copy link
Contributor

Hi,

Can you inform me how to proceed with the settings not available yet. When reading #167 we might see

  • Debries Field: 30%, 40%, 50%, 60%, 70%, 80% (the standard value is 30%).
  • DiDF- Defense into debris: 0, 30% 40% 50% 60%, 70% 80% (the standard is 0)

Can i assume these settings should be enums fields or free input fields, to be able to complete the server settings overlay.

Screenshot from 2024-08-23 15-53-40

Cheers

@lanedirt
Copy link
Owner Author

Hm, good question. Thanks for asking.

To be honest both options sound good to me. I think for simplicity free input fields will be sufficient. I do see adding enums / preset options a bonus which I think will help the admin user to know what the recommended option values are.

So in this case I'll leave it up to you to decide what you prefer (and how much time you have 😄).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants