-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add warmup run #11
base: main
Are you sure you want to change the base?
Add warmup run #11
Conversation
bench.py
Outdated
query_type, | ||
ingest, | ||
index, | ||
prefix + "-warmup", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think we need to create and ingest a whole new set of tables
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Make sense! Change to warmup with query only
@@ -86,6 +86,14 @@ def add_benchmark_args(parser: argparse.ArgumentParser): | |||
action=argparse.BooleanOptionalAction, | |||
help="drop tables before starting", | |||
) | |||
parser.add_argument( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we achieve the desired auto-scaling by just running queries? We already have a mechanism for that, we just need to expose it in the cli arguments
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ideally we don't want to create a bunch of tables just to warm up the cluster
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Change to scale up queries only, expose the warmup queries parameter which default to num of queries and can be specified by users
@QianZhu Please see if the new warmup_queries mechanism is what you are looking for? |
No description provided.