Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add warmup run #11

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Add warmup run #11

wants to merge 1 commit into from

Conversation

LuQQiu
Copy link
Contributor

@LuQQiu LuQQiu commented Nov 8, 2024

No description provided.

@QianZhu QianZhu requested a review from rpgreen November 8, 2024 17:47
bench.py Outdated
query_type,
ingest,
index,
prefix + "-warmup",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think we need to create and ingest a whole new set of tables

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Make sense! Change to warmup with query only

@@ -86,6 +86,14 @@ def add_benchmark_args(parser: argparse.ArgumentParser):
action=argparse.BooleanOptionalAction,
help="drop tables before starting",
)
parser.add_argument(
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we achieve the desired auto-scaling by just running queries? We already have a mechanism for that, we just need to expose it in the cli arguments

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ideally we don't want to create a bunch of tables just to warm up the cluster

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change to scale up queries only, expose the warmup queries parameter which default to num of queries and can be specified by users

@LuQQiu
Copy link
Contributor Author

LuQQiu commented Nov 13, 2024

@QianZhu Please see if the new warmup_queries mechanism is what you are looking for?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants