Samples for data logging #84
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DataLoggingNextGenTest is suitable for testing MICROBIT_LOG_MODE 2
|
@JohnVidler I don't really have a strong view re these sample changes being merged. They were useful for my testing at least. |
JohnVidler
added
documentation
Examples are generally good 👍 and I don't see any reason not to include these, especially if someone down the line wants to test additional logging options. That said, I think both of these could be the same samples file, with some additional comments on what they do. As these are minor changes I'll roll them into this PR and get this merged shortly. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DataLoggingNextGenTest is suitable for testing MICROBIT_LOG_MODE 2
Depends on lancaster-university/codal-microbit-v2#399