Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Multiplatform Gears (1) #20

Merged
merged 65 commits into from
Dec 1, 2023

Conversation

m8nmueller
Copy link
Contributor

This bundles the foundations for a platform-independent implementation of Gears, as well as the listener API and channels with read and write operation sources, capable of racing (selecting). It is the first of a couple upcoming steps to carve out the interface that will be provided by Gears.

belamenso and others added 30 commits October 27, 2023 15:57
bug-free extension methods still pending
... instead of `java.util.Duration`
m8nmueller and others added 26 commits November 20, 2023 16:05
- Inline the `ListenerLock` implementation in `race` to reduce allocations
- Inline `sources.filter.foreach`
- Remove eager cleanup behavior from `lock` implementation
Apply suggestions from code review

Co-authored-by: Maximilian Müller <[email protected]>
Co-authored-by: Maximilian Müller <[email protected]>
New implementation with `src` passed
Copy link
Contributor

@natsukagami natsukagami left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one thing: we need to update summary (and readme!) as this still reflects the very early design of everything. But the rest should be good!

@natsukagami
Copy link
Contributor

Nice, let's get the gears turning :D

@natsukagami natsukagami merged commit 1b374df into lampepfl:main Dec 1, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants