Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🎨 Integrate nbproject into lamindb #2066

Draft
wants to merge 4 commits into
base: main
Choose a base branch
from
Draft

🎨 Integrate nbproject into lamindb #2066

wants to merge 4 commits into from

Conversation

Koncopd
Copy link
Member

@Koncopd Koncopd commented Oct 17, 2024

No description provided.

@Koncopd Koncopd marked this pull request as draft October 17, 2024 12:44
Copy link

codecov bot commented Oct 17, 2024

Codecov Report

Attention: Patch coverage is 26.29108% with 157 lines in your changes missing coverage. Please review.

Project coverage is 90.40%. Comparing base (c41fc2c) to head (368773b).
Report is 5 commits behind head on main.

Files with missing lines Patch % Lines
lamindb/core/notebook/_filepath.py 11.70% 83 Missing ⚠️
lamindb/core/notebook/_pypackage.py 17.72% 65 Missing ⚠️
lamindb/core/notebook/_properties.py 73.52% 9 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2066      +/-   ##
==========================================
- Coverage   92.52%   90.40%   -2.12%     
==========================================
  Files          54       58       +4     
  Lines        6435     6640     +205     
==========================================
+ Hits         5954     6003      +49     
- Misses        481      637     +156     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

github-actions bot commented Oct 17, 2024

@github-actions github-actions bot temporarily deployed to pull request October 17, 2024 12:53 Inactive
@github-actions github-actions bot temporarily deployed to pull request October 17, 2024 13:21 Inactive
Comment on lines +17 to +18
# grab source
text = "".join(cell["source"])
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❤️ great

@falexwolf falexwolf changed the title ♻️ Integrate nbproject utilities into lamindb 🎨 Integrate nbproject into lamindb Oct 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants