-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
✨ Rename --force in delete to --confirm/--no-confirm #61
base: main
Are you sure you want to change the base?
Conversation
Signed-off-by: zethson <[email protected]>
It's been so far a technical internal parameter. I see that it'd be sometimes useful for CI runs, but I was worried about people accidentally using it. If we think the danger is low, we should only briefly ponder whether this is an ideal name.
|
This is actually behavior that I would have expected under a |
Having an "actual" |
…ature/require_empty
Signed-off-by: zethson <[email protected]>
Signed-off-by: zethson <[email protected]>
@falexwolf all right. |
This is great! We'll just need to either update all notebooks and scripts everywhere to reflect it or this change should be made in a backward-compatible way together with renaming the param within lamindb-setup. I suggest to make it backward compatible so that we have more time with the renaming (it'd be quite a bit of work). |
See title.