Skip to content

Commit

Permalink
qa: incorporate feedback from review
Browse files Browse the repository at this point in the history
- Removes unnecessary parameter annotations.
- Adds typehints where needed and useful.
- Fixes annotations where they were incorrect.
  • Loading branch information
weierophinney committed Nov 6, 2019
1 parent a22283c commit a051753
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 5 deletions.
5 changes: 1 addition & 4 deletions src/ConfigPostProcessor.php
Original file line number Diff line number Diff line change
Expand Up @@ -87,7 +87,7 @@ function ($value, array $keys) {
* nested configuration.
* @return array
*/
public function __invoke(array $config, $keys = [])
public function __invoke(array $config, array $keys = [])
{
$rewritten = [];

Expand Down Expand Up @@ -162,8 +162,6 @@ private function replace($value, array $keys, $key = null)
* Based on zend-stdlib Zend\Stdlib\ArrayUtils::merge
* @copyright Copyright (c) 2005-2015 Zend Technologies USA Inc. (http://www.zend.com)
*
* @param array $a
* @param array $b
* @return array
*/
public static function merge(array $a, array $b)
Expand Down Expand Up @@ -243,7 +241,6 @@ private function replaceExactValue($value)
* This same logic can be used for invokables, which are essentially just
* an alias map.
*
* @param array $value
* @return array
*/
private function replaceDependencyAliases(array $aliases)
Expand Down
2 changes: 1 addition & 1 deletion src/Module.php
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,7 @@ public function init($moduleManager)
* Type-hinting deliberately omitted to allow unit testing
* without dependencies on packages that do not exist yet.
*
* @param ModuleEvent $moduleEvent
* @param ModuleEvent $event
*/
public function onMergeConfig($event)
{
Expand Down

0 comments on commit a051753

Please sign in to comment.