Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PHP 8.3 support added #219

Closed
wants to merge 2 commits into from
Closed

PHP 8.3 support added #219

wants to merge 2 commits into from

Conversation

glo71317
Copy link

Q A
Documentation yes/no
Bugfix yes/no
BC Break yes/no
New Feature yes/no
RFC yes/no
QA yes/no

Description

gsteel
gsteel requested changes Oct 17, 2023
View reviewed changes
Copy link
Member

@gsteel gsteel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In order to run tests on 8.3, you'll need to ignore platform requirements for 8.3 in .laminas-ci.json too

@Ocramius Ocramius changed the base branch from 2.31.x to 2.32.x October 17, 2023 23:27
@glo71317
Copy link
Author

In order to run tests on 8.3, you'll need to ignore platform requirements for 8.3 in .laminas-ci.json too

I have updated

gsteel
gsteel requested changes Oct 18, 2023
View reviewed changes
.laminas-ci.json Show resolved Hide resolved
@fezfez fezfez mentioned this pull request Nov 3, 2023
Merged
@gsteel
Copy link
Member

gsteel commented Nov 3, 2023

Thanks @glo71317 but this has been handled in #226

@gsteel gsteel closed this Nov 3, 2023
@gsteel gsteel self-assigned this Nov 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gsteel gsteel gsteel requested changes

Assignees

@gsteel gsteel

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@glo71317 @gsteel