Remove Stream Wrapper Functionality #129
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gsteel
force-pushed
the
remove-stream-wrapper
branch
from
6210995 to
e50297e
Compare
Ocramius
approved these changes
Feb 1, 2022
|
IMO OK, but CI didn't run at all now? 🤔 |
|
It's weird. I forced pushed with a cs fix and nothing ran 🤷♂️ I think this time it was a GH thing. There's a failed run in the history. |
|
Checking the CI run @ https://github.com/laminas/laminas-view/runs/5014074970?check_suite_focus=true#step:3:374 (not reported in here 🤷 ) |
|
Yes, CI ran fine - I spotted the CS violation, fixed, amended and force-pushed - then GH refused to re-run the matrix. Can you hit "Re-Run all jobs" there for me? I don't have permission to do that, or I can find something arbitrary to commit… |
|
@gsteel I did re-trigger CI, but it only re-ran on the commit previous to your force-push. Could you perhaps rebase and force-push, to trigger it from your end? |
- Updates the path stack template resolver removing deprecated methods related to stream wrapper - Removes the Stream wrapper class - Updates psalm baseline Signed-off-by: George Steel <[email protected]>
gsteel
force-pushed
the
remove-stream-wrapper
branch
from
e50297e to
90a4794
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Closes #29
Closes #28
Deprecated in #91