Minor psalm issue fixes

Signed-off-by: George Steel <[email protected]>
laminas · Jan 8, 2024 · f3cb0ad · f3cb0ad
1 parent db521c5
commit f3cb0ad
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 12 deletions.
diff --git a/psalm-baseline.xml b/psalm-baseline.xml
@@ -1,5 +1,5 @@
 <?xml version="1.0" encoding="UTF-8"?>
-<files psalm-version="5.16.0@2897ba636551a8cb61601cc26f6ccfbba6c36591">
+<files psalm-version="5.18.0@b113f3ed0259fd6e212d87c3df80eec95a6abf19">
  <file src="src/Helper/AbstractHtmlElement.php">
  <MissingConstructor>
  <code>$closingBracket</code>
@@ -135,16 +135,13 @@
  </MissingConstructor>
  <MixedArgument>
  <code>$item</code>
- <code>$messagesToPrint</code>
+ <code>$item</code>
  </MixedArgument>
  <MixedArgumentTypeCoercion>
  <code>$classes</code>
  <code>$classes</code>
+ <code>$messagesToPrint</code>
  </MixedArgumentTypeCoercion>
- <MixedArrayAssignment>
- <code>$messagesToPrint[]</code>
- <code>$messagesToPrint[]</code>
- </MixedArrayAssignment>
  <MixedAssignment>
  <code>$classes</code>
  <code>$classes</code>
@@ -722,9 +719,6 @@
  <PossiblyNullPropertyAssignmentValue>
  <code>null</code>
  </PossiblyNullPropertyAssignmentValue>
- <PossiblyUndefinedArrayOffset>
- <code>$found[0]</code>
- </PossiblyUndefinedArrayOffset>
  <RedundantCastGivenDocblockType>
  <code>(int) $renderFlag</code>
  </RedundantCastGivenDocblockType>
@@ -1802,6 +1796,9 @@
  <code>$name</code>
  <code>$name</code>
  </MoreSpecificImplementedParamType>
+ <PossiblyUndefinedArrayOffset>
+ <code>$params[$param]</code>
+ </PossiblyUndefinedArrayOffset>
  </file>
  <file src="test/Helper/CycleTest.php">
  <RedundantCastGivenDocblockType>

diff --git a/test/ViewTest.php b/test/ViewTest.php
@@ -215,7 +215,6 @@ public function testResponseStrategyIsNotTriggeredForChildModel(): void
 
  $result = [];
  $this->view->addResponseStrategy(function (ViewEvent $e) use (&$result) {
- self::assertIsArray($result);
  /** @psalm-var mixed */
  $result[] = $e->getResult();
  });
@@ -232,8 +231,7 @@ public function testResponseStrategyIsNotTriggeredForChildModel(): void
 
  $this->view->render($this->model);
 
- self::assertIsArray($result);
- self::assertEquals(1, count($result));
+ self::assertCount(1, $result);
  }
 
  public function testUsesTreeRendererInterfaceToDetermineWhetherOrNotToPassOnlyRootViewModelToPhpRenderer(): void