Fix #135: better GPS point validator detection of invalid coordinate numeric conversions #169
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ocramius
requested changes
Jan 12, 2023
|
As this is a bugfix, it should target |
codisart
force-pushed
the
bug-135-fix-GPS-point-validator
branch
from
9220418 to
0675923
Compare
codisart
force-pushed
the
bug-135-fix-GPS-point-validator
branch
from
0675923 to
6be9176
Compare
codisart
force-pushed
the
bug-135-fix-GPS-point-validator
branch
from
6be9176 to
c0327a4
Compare
codisart
requested review from
Ocramius and
froschdesign
and removed request for
Ocramius and
froschdesign
codisart
force-pushed
the
bug-135-fix-GPS-point-validator
branch
from
0063e10 to
ac2b278
Compare
Signed-off-by: codisart <[email protected]>
Signed-off-by: codisart <[email protected]>
Signed-off-by: codisart <[email protected]>
…number Signed-off-by: codisart <[email protected]>
codisart
force-pushed
the
bug-135-fix-GPS-point-validator
branch
from
ac2b278 to
df312bf
Compare
codisart
force-pushed
the
bug-135-fix-GPS-point-validator
branch
2 times, most recently
from
a0eddb7 to
83155a0
Compare
…e is_numeric function to separate cases. Signed-off-by: codisart <[email protected]>
codisart
force-pushed
the
bug-135-fix-GPS-point-validator
branch
from
83155a0 to
4923b71
Compare
Ocramius
approved these changes
Feb 22, 2024
Ocramius
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR is trying to fix the issue #135.
The fix is to have the string "foo" not converted to 0.0 and validated as a correct coordinate.