Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

File extension comparison treats some distinct extensions as equal #98 #104

Closed
wants to merge 1 commit into from
Closed

File extension comparison treats some distinct extensions as equal #98 #104

wants to merge 1 commit into from

Conversation

fgsl
Copy link

@fgsl fgsl commented Jul 13, 2021

Q A
Documentation no
Bugfix yes
BC Break no
New Feature no
RFC no
QA yes

Description

This change is necessary because it fixes a bug of file extension comparison

  • You can reproduce the bug trying to compare a file with extension '10' with another with extension '010'
  • Class ExcludeExtension must return FALSE, because extensions are different
  • However, current implementation will said that both of files have the same extension.
  • TARGET THE master BRANCH

@fgsl fgsl mentioned this pull request Jul 13, 2021
Closed
@weierophinney
Copy link
Member

This was addressed in #10, when applying laminas-coding-standard v2, and will be released with 2.14.5.

@Zenexer
Copy link

Zenexer commented Jul 14, 2021

6413824#diff-77e911345bc3997d7fb8bbde4b8b349812819570ab56b3831e8f689967bb42c6L63

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@fgsl @weierophinney @Zenexer