Fix assertTemplateName() checking only the first leaf in the view model tree.
#87
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Please use descriptive title. It will be an entry in the release notes. |
visto9259
changed the title
assertTemplateName returns too early
visto9259
changed the title
assertTemplateName returns too earlyassertTemplateName returns too early
gsteel
previously requested changes
Sep 13, 2024
Xerkus
changed the title
assertTemplateName returns too earlyassertTemplateName() checking only the first leaf in the view model tree.
…ll children until found. Added test case and supporting assets to test nested views. Signed-off-by: Eric Richer [email protected] <[email protected]>
…prove test case to test deeper viewer hierarchy Signed-off-by: Eric Richer [email protected] <[email protected]>
…php and deleted TemplateNameTest.php Signed-off-by: Eric Richer [email protected] <[email protected]>
|
Tests for the template assertion seem to be missing for a case where templates are not found, or found for Use try catch block instead of expected exception assertion because assertion exceptions are PhpUnit's and might have special handling attached to them. |
… when the template is not found and the 'assertNotTemplateName' fails when the template is found Signed-off-by: Eric Richer [email protected] <[email protected]>
|
That was counter intuitive. Adding tests to check that PHPUnit fails... |
|
Well, we are not checking that phpunit fails. We are checking that assertion succeeds. |
Xerkus
reviewed
Sep 16, 2024
Xerkus
requested changes
Sep 16, 2024
… the template is not found and the 'assertNotTemplateName' fails when the template is found. to separate test cases. Signed-off-by: Eric Richer [email protected] <[email protected]>
visto9259
force-pushed
the
fix/3
branch
2 times, most recently
from
08b85fc
to
3a8099a
Compare
Signed-off-by: Eric Richer [email protected] <[email protected]>
…ertTemplateName()' and 'assertNotTemplateName()' Signed-off-by: Eric Richer [email protected] <[email protected]>
…eNameFailsWhenNotFound()' and 'testAssertNotTemplateNameFailsWhenFound()' Signed-off-by: Eric Richer [email protected] <[email protected]>
Xerkus
approved these changes
Sep 16, 2024
|
CI run stuck |
|
@visto9259 thank you |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes #3.
The protected function
AbstractControllerTestCase::searchTemplates()will now traverse all view model children until the template is found, returning false if not found in any children.