Update require php to ~8.4.0 #118
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Raphael Stolt <[email protected]>
raphaelstolt
force-pushed
the
require-php-8.4
branch
from
d97d1af to
4245a22
Compare
|
8.4 is not yet available in CI. The supported range won't be updated until we can verify that all tests pass on 8.4 |
|
It's available. |
Show me in the checks below where this lib was tested on 8.4 |
|
I can just link a GitHub Actions job where PHP 8.4 is successfully installed, so generally it's available. |
|
@raphaelstolt the issue seem to be adressed, can you run the ci again |
|
Needs adjusting 😁 Probably need to ignore platform requirements on PHP 8.4 |
|
Are we waiting for vemio/psalm PR with PHP 8.4 support to get merged for this to unblock ? |
|
Thanks for your help here @raphaelstolt but this has been implemented in #119 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Makes the laminas-stdlib available for PHP 8.4.