Better documentation for delegators and service aliases #91
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gsteel
force-pushed
the
docs/delegators-and-aliases
branch
from
9efada8 to
ffd1bd6
Compare
|
Added 2 commits that fix a couple of linting errors elsewhere in the docs. The PHPCS failure is not fixable without upgrading Laminas Coding Standard as per #87 |
froschdesign
requested changes
Jul 19, 2021
gsteel
force-pushed
the
docs/delegators-and-aliases
branch
from
7fefadd to
810f684
Compare
boesing
force-pushed
the
docs/delegators-and-aliases
branch
from
810f684 to
a3dbffd
Compare
|
I've retargeted 3.7.x and rebased against that. codestyle checks should pass as of now. |
Ocramius
changed the title
…or of delegators when applied to aliases is made clear Signed-off-by: George Steel <[email protected]>
…gard to aliases. Signed-off-by: George Steel <[email protected]>
Signed-off-by: George Steel <[email protected]>
Signed-off-by: George Steel <[email protected]>
Co-authored-by: Frank Brückner <[email protected]> Signed-off-by: George Steel <[email protected]>
…n_ occur for aliased services Signed-off-by: George Steel <[email protected]>
Ocramius
force-pushed
the
docs/delegators-and-aliases
branch
from
a3dbffd to
de134d3
Compare
|
Applied minor CS fixes, rebased and merging now :-) GPG signatures most likely unverifiable due to rebase by third-party (me), but also not required here. |
Ocramius
approved these changes
Jul 24, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
More information in #90 - This pull adds information to delegators.md to illustrate delegator behaviour wrt service aliases.
I also added a fairly verbose test case to illustrate.
Hang fire whilst I force push for DCO 😅
Fixes #90