Skip to content

Commit

Permalink
Merge pull request #193 from boesing/qa/mark-deprecations
Browse files Browse the repository at this point in the history
Mark `Config` and `ConfigInterface` as deprecated
  • Loading branch information
boesing authored May 14, 2023
2 parents 7aebff6 + e916139 commit 625f2aa
Show file tree
Hide file tree
Showing 3 changed files with 14 additions and 1 deletion.
11 changes: 10 additions & 1 deletion psalm-baseline.xml
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
<?xml version="1.0" encoding="UTF-8"?>
<files psalm-version="5.8.0@9cf4f60a333f779ad3bc704a555920e81d4fdcda">
<files psalm-version="5.9.0@8b9ad1eb9e8b7d3101f949291da2b9f7767cd163">
<file src="src/AbstractFactory/ConfigAbstractFactory.php">
<InvalidStringClass>
<code>new $requestedName(...$arguments)</code>
Expand Down Expand Up @@ -59,6 +59,9 @@
<code>$config</code>
<code>$config</code>
</ArgumentTypeCoercion>
<DeprecatedInterface>
<code>null|ConfigInterface|ContainerInterface</code>
</DeprecatedInterface>
<ImplementedParamTypeMismatch>
<code>$service</code>
</ImplementedParamTypeMismatch>
Expand All @@ -79,6 +82,9 @@
</UnusedPsalmSuppress>
</file>
<file src="src/Config.php">
<DeprecatedInterface>
<code>Config</code>
</DeprecatedInterface>
<LessSpecificReturnStatement>
<code>ArrayUtils::merge($a, $b)</code>
</LessSpecificReturnStatement>
Expand Down Expand Up @@ -510,6 +516,9 @@
</UnusedClosureParam>
</file>
<file src="test/ConfigTest.php">
<DeprecatedClass>
<code>new Config($config)</code>
</DeprecatedClass>
<MixedAssignment>
<code>$configInstance</code>
<code>$configuration</code>
Expand Down
2 changes: 2 additions & 0 deletions src/Config.php
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,8 @@
* These features are advanced, and not typically used. If you wish to use them,
* you will need to require the laminas-stdlib package in your application.
*
* @deprecated Class will be removed as of v4.0
*
* @psalm-import-type ServiceManagerConfigurationType from ConfigInterface
*/
class Config implements ConfigInterface
Expand Down
2 changes: 2 additions & 0 deletions src/ConfigInterface.php
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,8 @@
use Psr\Container\ContainerInterface;

/**
* @deprecated Interface will be removed as of v4.0
*
* @see ContainerInterface
* @see ArrayAccess
*
Expand Down

0 comments on commit 625f2aa

Please sign in to comment.