Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes #3 - _getCacheInternalId() is too generic #6

Merged
merged 3 commits into from
Jun 22, 2020
Merged

Fixes #3 - _getCacheInternalId() is too generic #6

merged 3 commits into from
Jun 22, 2020

Conversation

froschdesign
Copy link
Member

Q A
Bugfix yes

@froschdesign froschdesign added the Bug Something isn't working label Jun 18, 2020
@froschdesign froschdesign linked an issue Jun 18, 2020 that may be closed by this pull request
2.8 _getCacheInternalId() is too generic #3
Closed
@froschdesign froschdesign mentioned this pull request Jun 18, 2020
Closed
michalbundyra
michalbundyra approved these changes Jun 22, 2020
View reviewed changes
Copy link
Member

@michalbundyra michalbundyra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@froschdesign LGTM 👍

As discussed, it looks like coverage is broken. I've checked locally and new internal method is definitely called in tests.

@michalbundyra michalbundyra added this to the 2.8.3 milestone Jun 22, 2020
weierophinney
weierophinney requested changes Jun 22, 2020
View reviewed changes
src/Paginator.php Show resolved Hide resolved
@weierophinney weierophinney merged commit 667493a into laminas:master Jun 22, 2020
weierophinney added a commit that referenced this pull request Jun 22, 2020
@weierophinney
docs: adds CHANGELOG entry for #6
ffc8ffc 
Signed-off-by: Matthew Weier O'Phinney <[email protected]>
weierophinney added a commit that referenced this pull request Jun 22, 2020
@weierophinney
Merge branch 'hotfix/6-cache-internal-id' into develop
ce834f0 
Forward port #6

Conflicts:
	CHANGELOG.md
@froschdesign froschdesign deleted the hotfix/3 branch June 22, 2020 17:16
@FabianKoestring FabianKoestring mentioned this pull request Sep 30, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@michalbundyra michalbundyra michalbundyra approved these changes

@weierophinney weierophinney weierophinney approved these changes

Assignees
No one assigned
Labels
Bug Something isn't working
Projects
None yet
Milestone
2.8.3
Development

Successfully merging this pull request may close these issues.

2.8 _getCacheInternalId() is too generic
3 participants
@froschdesign @weierophinney @michalbundyra