Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove support for PHP 8.0, Add support for PHP 8.3 #51

Merged
merged 1 commit into from
Nov 14, 2023

Conversation

glo71317
Copy link
Contributor

Q A
Documentation yes/no
Bugfix yes/no
BC Break yes/no
New Feature yes/no
RFC yes/no
QA yes/no

Description

@glo71317 glo71317 force-pushed the php_8.3 branch 2 times, most recently from 8342b80 to 15b90d1 Compare November 14, 2023 08:22
@glo71317
Copy link
Contributor Author

@Ocramius along with this PR, Following PRs are ready for merge.

https://github.com/laminas/laminas-file/pull/15
https://github.com/laminas/laminas-mvc/pull/159
https://github.com/laminas/laminas-oauth/pull/21
https://github.com/laminas/laminas-server/pull/72
https://github.com/laminas/laminas-mvc-plugin-flashmessenger/pull/36

Few below prs having some dependencies issue

https://github.com/laminas/laminas-db/pull/293
https://github.com/laminas/laminas-cache-storage-deprecated-factory/pull/5

If you don't mind can you please take a look above PRs on priorities so that we can unblock to update dependencies in Magento side.

@Ocramius
Copy link
Member

These two need a check by @laminas/technical-steering-committee, since the entire PHPCS changeset got suppressed:

laminas/laminas-db will probably happen sometime in 2024 due to MS SQL Server support simply not being there: laminas/laminas-db#293 (comment) If we don't test it, we don't support it, and dropping support is a major BC break.

@glo71317
Copy link
Contributor Author

@Ocramius Thank you so much for quick response!
laminas/laminas-file#15
laminas/laminas-oauth#21
for above both the pr changes, we have entire PHPCS changeset got suppressed as of now because if we go for fixes then lot of file changes will be there if you are agree then we can contribute for the same.

laminas/laminas-db will probably happen sometime in 2024 - It will too late for us, Please discuss internally and let us know about all above three pr changes. there is any way to get it done as soon as possible.

We are ready to instant help regarding the same. Thanks

@Ocramius
Copy link
Member

laminas/laminas-db will probably happen sometime in 2024 - It will too late for us, Please discuss internally and let us know about all above three pr changes. there is any way to get it done as soon as possible.

You can certainly get in contact with Microsoft about their SQL Server support: that would help speed things up.

We depend on it, and won't release without testing that first: I can imagine they'd need time to do a release themselves too.

I would also take a moment to remind that you (personally and Adobe Commerce) are a user of a freely provided "as is" library: we do what we can, when we can, and also when we feel like it.
If Adobe wants to get guaranteed release schedules on their own terms, I'd expect them to get in direct contact with the TSC and Linux foundation to have some of our work sponsored properly.

Copy link
Member

@gsteel gsteel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @glo71317 - This patch LGTM 👍

@gsteel gsteel changed the title PHP 8.3 support added Remove support for PHP 8.0, Add support for PHP 8.3 Nov 14, 2023
@gsteel gsteel self-assigned this Nov 14, 2023
@gsteel gsteel added this to the 2.19.0 milestone Nov 14, 2023
@gsteel
Copy link
Member

gsteel commented Nov 14, 2023

@Ocramius - merging this patch because it looks like discussion relates to other libs

@gsteel gsteel merged commit 9d212fb into laminas:2.19.x Nov 14, 2023
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
No open projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants