-
-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove support for PHP 8.0, Add support for PHP 8.3 #51
Conversation
8342b80
to
15b90d1
Compare
@Ocramius along with this PR, Following PRs are ready for merge.
Few below prs having some dependencies issue
If you don't mind can you please take a look above PRs on priorities so that we can unblock to update dependencies in Magento side. |
These two need a check by @laminas/technical-steering-committee, since the entire PHPCS changeset got suppressed:
|
@Ocramius Thank you so much for quick response! laminas/laminas-db will probably happen sometime in 2024 - It will too late for us, Please discuss internally and let us know about all above three pr changes. there is any way to get it done as soon as possible. We are ready to instant help regarding the same. Thanks |
You can certainly get in contact with Microsoft about their SQL Server support: that would help speed things up. We depend on it, and won't release without testing that first: I can imagine they'd need time to do a release themselves too. I would also take a moment to remind that you (personally and Adobe Commerce) are a user of a freely provided "as is" library: we do what we can, when we can, and also when we feel like it. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @glo71317 - This patch LGTM 👍
@Ocramius - merging this patch because it looks like discussion relates to other libs |
Description