Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Initial view helpers #1

Merged
merged 13 commits into from
Nov 26, 2024
Merged

Initial view helpers #1

Show file tree
Hide file tree
Changes from 12 commits
Commits
Show all changes
13 commits
Select commit Hold shift + click to select a range
7f40bc0
Adds replacement `ServerUrl` helper
gsteel Jul 29, 2022
b5c7444
config.platform should be 7.4.99
gsteel Aug 8, 2022
e160df6
Introduce a thin wrapper around webmozart/assert marking as `@internal`
gsteel Aug 8, 2022
2dac760
Introduce a factory for the Doctype view helper.
gsteel Aug 8, 2022
f29846f
Add Url helper to preserve BC with legacy `Laminas\View\Helper\Url`
gsteel Aug 8, 2022
70fcbc6
Removes affordance to the deprecated `ModuleRouteListener` in Url helper
gsteel Aug 22, 2022
ffbcaf6
Adds notes for changes required to MVC
gsteel Aug 22, 2022
7dc6604
Updates locked dependencies
gsteel Aug 22, 2022
23f947e
Drop support for PHP 7.4, add support for PHP 8.2
gsteel Nov 9, 2022
a33c128
Remove baseline in favour of inline suppression
gsteel Nov 9, 2022
73539b6
Bump all dependencies
gsteel Jul 18, 2023
e01b72e
Remove empty method for dependency configuration
gsteel Jul 18, 2023
016f5e3
Remove TODO list
gsteel Jul 19, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .gitignore
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,5 +3,5 @@
/laminas-mkdoc-theme/
/phpunit.xml
/vendor/
.phpunit.result.cache
.phpunit.cache
.phpcs-cache
5 changes: 5 additions & 0 deletions MVC-TODO.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
# Changes Required for `laminas/mvc`

The URL view helper factory is a [closure created here](https://github.com/laminas/laminas-mvc/blob/3.4.x/src/Service/ViewHelperManagerFactory.php#L73-L100). This closure will need to be changed to inject the router and route match instances into the helper constructor, or, removed completely to favour the shipped `UrlFactory`.

The [Doctype factory in ViewHelperManagerFactory](https://github.com/laminas/laminas-mvc/blob/3.4.x/src/Service/ViewHelperManagerFactory.php#L131-L152) can be dropped in favour of the shipped factory.
gsteel marked this conversation as resolved.
Show resolved Hide resolved
26 changes: 16 additions & 10 deletions composer.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,24 +18,29 @@
"config": {
"sort-packages": true,
"platform": {
"php": "7.4"
"php": "8.1.99"
},
"allow-plugins": {
"dealerdirect/phpcodesniffer-composer-installer": true
}
},
"require": {
"php": "^7.4 || ~8.0.0 || ~8.1.0",
"laminas/laminas-http": "^2.15",
"laminas/laminas-servicemanager": "^3.16.0",
"psr/container": "^1 || ^2"
"php": "~8.1.0 || ~8.2.0",
"laminas/laminas-http": "^2.18",
"laminas/laminas-mvc": "^3.6.1",
"laminas/laminas-router": "^3.11.1",
"laminas/laminas-servicemanager": "^3.21",
"laminas/laminas-stdlib": "^3.17",
"laminas/laminas-view": "^2.28",
"psr/container": "^1.1.2 || ^2",
"webmozart/assert": "^1.11.0"
},
"require-dev": {
"laminas/laminas-coding-standard": "~2.3.0",
"maglnet/composer-require-checker": "^3.8",
"phpunit/phpunit": "^9.5.21",
"psalm/plugin-phpunit": "^0.17.0",
"vimeo/psalm": "^4.25.0"
"laminas/laminas-coding-standard": "~2.4.0",
"maglnet/composer-require-checker": "^4.6",
"phpunit/phpunit": "^10.2.6",
"psalm/plugin-phpunit": "^0.18.4",
"vimeo/psalm": "^5.13.1"
},
"autoload": {
"psr-4": {
Expand All @@ -50,6 +55,7 @@
"scripts": {
"check": [
"@cs-check",
"psalm --stats",
"@test"
],
"cs-check": "phpcs",
Expand Down
Loading