Skip to content

Commit

Permalink
Adds notes for changes required to MVC
Browse files Browse the repository at this point in the history
  • Loading branch information
gsteel committed Aug 22, 2022
1 parent 3a3f3c9 commit 33e7631
Showing 1 changed file with 5 additions and 0 deletions.
5 changes: 5 additions & 0 deletions MVC-TODO.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
# Changes Required for `laminas/mvc`

The URL view helper factory is a [closure created here](https://github.com/laminas/laminas-mvc/blob/3.4.x/src/Service/ViewHelperManagerFactory.php#L73-L100). This closure will need to be changed to inject the router and route match instances into the helper constructor, or, removed completely to favour the shipped `UrlFactory`.

The [Doctype factory in ViewHelperManagerFactory](https://github.com/laminas/laminas-mvc/blob/3.4.x/src/Service/ViewHelperManagerFactory.php#L131-L152) can be dropped in favour of the shipped factory.

0 comments on commit 33e7631

Please sign in to comment.