-
-
Notifications
You must be signed in to change notification settings - Fork 52
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow disabled- and form-Attribute on fieldsets #255
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Thomas Müller <[email protected]>
@mimmi20 laminas-form/src/View/Helper/FormCollection.php Lines 139 to 141 in 06ececc
A replacement can be: if (! $this->getDoctypeHelper()->isHtml5()) {
unset(
$attributes['name'],
$attributes['disabled'],
$attributes['form']
);
} The laminas-form/src/View/Helper/FormCollection.php Lines 80 to 83 in 06ececc
|
Signed-off-by: Thomas Müller <[email protected]>
froschdesign
reviewed
Jan 4, 2024
froschdesign
reviewed
Jan 4, 2024
Signed-off-by: Thomas Müller <[email protected]>
Signed-off-by: Thomas Müller <[email protected]>
Slamdunk
approved these changes
Jan 9, 2024
Thank you 🎊 |
froschdesign
changed the title
allow disabled- and form-Attribute on fieldsets
Allow disabled- and form-Attribute on fieldsets
Jan 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR wants to allow the Attributes "disabled" and "form" on fieldsets. This is related to Issue #155.