Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Disable PHPUnits ErrorHandler for LegacyStyleTests #254

Merged
merged 1 commit into from
Jan 3, 2024
Merged

Disable PHPUnits ErrorHandler for LegacyStyleTests #254

merged 1 commit into from
Jan 3, 2024

Conversation

mimmi20
Copy link
Contributor

@mimmi20 mimmi20 commented Jan 3, 2024

Q A
Documentation no
Bugfix yes
BC Break no
New Feature no
RFC no
QA no

Description

This PR wants to fix some Unittests.

@froschdesign
Copy link
Member

Reference: https://docs.phpunit.de/en/10.5/error-handling.html#disabling-phpunit-s-error-handler

@gsteel gsteel self-assigned this Jan 3, 2024
@gsteel gsteel added this to the 3.18.0 milestone Jan 3, 2024
gsteel
gsteel approved these changes Jan 3, 2024
View reviewed changes
Copy link
Member

@gsteel gsteel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @mimmi20

@gsteel gsteel merged commit da14621 into laminas:3.18.x Jan 3, 2024
11 checks passed
@mimmi20 mimmi20 deleted the fix-build branch January 4, 2024 09:11
@froschdesign froschdesign changed the title disable PHPUnits ErrorHandler for LegacyStyleTests Disable PHPUnits ErrorHandler for LegacyStyleTests Jan 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gsteel gsteel gsteel approved these changes

Assignees

@gsteel gsteel

Labels
Enhancement
Projects
None yet
Milestone
3.18.0
Development

Successfully merging this pull request may close these issues.
3 participants
@mimmi20 @froschdesign @gsteel