Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Return null when there is no feed link. #45

Open
wants to merge 1 commit into
base: 2.16.x
Choose a base branch
from

Conversation

Crell
Copy link
Contributor

@Crell Crell commented Nov 18, 2021

Q A
Documentation no
Bugfix yes
BC Break no
New Feature no
RFC no
QA no

Description

Fixes #44.

At least I think so; the dev dependencies are fixed at PHP 8-incompatible versions so I can't actually run the code locally. I think this is the right fix, but someone with an older PHP version available should check my work.

@froschdesign
Copy link
Member

@Crell

I think this is the right fix…

Thanks for this pull request but we need a test case for this change.

@Ocramius Ocramius added the Bug Something isn't working label Mar 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

feedLink() is broken, returns invalid data if not found
3 participants