Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(levm): remove implicit as conversions #1170

Merged
merged 5 commits into from
Nov 14, 2024
Merged

fix(levm): remove implicit as conversions #1170

merged 5 commits into from
Nov 14, 2024

Conversation

maximopalopoli
Copy link
Contributor

@maximopalopoli maximopalopoli commented Nov 14, 2024 •
edited
Loading

Motivation

We have recently removed as conversions because they panicked, but there were left some implicit conversions left.

Description

This is done by using .try_into() and then maping the error to a VMError::VeryLargeNumber

@maximopalopoli maximopalopoli self-assigned this Nov 14, 2024
@maximopalopoli maximopalopoli added the levm Lambda EVM implementation label Nov 14, 2024
@maximopalopoli maximopalopoli marked this pull request as ready for review November 14, 2024 15:36
@maximopalopoli maximopalopoli requested a review from a team as a code owner November 14, 2024 15:36
@ilitteri ilitteri added this pull request to the merge queue Nov 14, 2024
Merged via the queue into main with commit ee714e4 Nov 14, 2024
18 checks passed
@ilitteri ilitteri deleted the levm/fix/remove-implicit-as-conversions branch November 14, 2024 16:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ilitteri ilitteri ilitteri approved these changes

Assignees

@maximopalopoli maximopalopoli

Labels
levm Lambda EVM implementation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@maximopalopoli @ilitteri