Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add function to get ABI from non-etherscan addresses #50

Open
wants to merge 15 commits into
base: main
Choose a base branch
from
Open

Add function to get ABI from non-etherscan addresses #50

wants to merge 15 commits into from

Conversation

mfachal
Copy link
Contributor

@mfachal mfachal commented May 17, 2022

linked to #22

@mfachal mfachal marked this pull request as ready for review May 27, 2022 17:52
@mfachal mfachal changed the title [WIP] add function to get ABI from non-etherscan addresses Add function to get ABI from non-etherscan addresses May 27, 2022
mmsc2
mmsc2 reviewed May 27, 2022
View reviewed changes
eth_client/lib/eth_client/abi.ex Outdated Show resolved Hide resolved
eth_client/lib/eth_client/contract.ex Outdated Show resolved Hide resolved
iver
iver previously approved these changes Jun 6, 2022
View reviewed changes
Copy link

@iver iver left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

eth_client/lib/eth_client/abi.ex Outdated Show resolved Hide resolved
eth_client/lib/eth_client/contract.ex Outdated Show resolved Hide resolved
@mfachal mfachal linked an issue Jun 8, 2022 that may be closed by this pull request
EthClient.Contract.get_functions/1 only works with etherscan connected chains #22
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mmsc2 mmsc2 mmsc2 left review comments

@iver iver iver left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

EthClient.Contract.get_functions/1 only works with etherscan connected chains
3 participants
@mfachal @iver @mmsc2