Javadoc and try-with-catch for parser

lahsivjar · Nov 8, 2024 · 82800a7 · 82800a7
1 parent 70b12de
commit 82800a7
Showing 1 changed file with 12 additions and 5 deletions.
diff --git a/x-pack/plugin/core/src/main/java/org/elasticsearch/xpack/core/ilm/LifecyclePolicyUtils.java b/x-pack/plugin/core/src/main/java/org/elasticsearch/xpack/core/ilm/LifecyclePolicyUtils.java
@@ -56,17 +56,24 @@ public static LifecyclePolicy loadPolicy(
         }
     }
 
+    /**
+     * Parses lifecycle policy based on the provided content type without doing any variable substitution.
+     * It is caller's responsibility to do any variable substitution if required.
+     */
     public static LifecyclePolicy parsePolicy(
         String rawPolicy,
         String name,
         NamedXContentRegistry xContentRegistry,
         XContentType contentType
     ) throws IOException {
-        XContentParser parser = contentType.xContent()
-            .createParser(XContentParserConfiguration.EMPTY.withRegistry(xContentRegistry), rawPolicy);
-        LifecyclePolicy policy = LifecyclePolicy.parse(parser, name);
-        policy.validate();
-        return policy;
+        try (
+            XContentParser parser = contentType.xContent()
+                .createParser(XContentParserConfiguration.EMPTY.withRegistry(xContentRegistry), rawPolicy)
+        ) {
+            LifecyclePolicy policy = LifecyclePolicy.parse(parser, name);
+            policy.validate();
+            return policy;
+        }
     }
 
     private static String replaceVariables(String template, Map<String, String> variables) {