Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Patch SyntaxError with container query #28

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

wegry
Copy link

@wegry wegry commented Oct 27, 2022

#26 (comment)

This PR is mostly to highlight the bug above. A better fix might be in csso itself.

@wegry wegry closed this Nov 11, 2022
@mykhailo-zakharov-duda-co

is this fix released?

@k0nserv
Copy link

k0nserv commented Jul 4, 2024

@wegry Why did you close this, it seems fine to me and csso seems to support @container queries just fine(see screenshot). @lahmatiy any chance something like this could be merged and released?

image

lookback-hugotunius added a commit to lookback/lookbook that referenced this pull request Jul 4, 2024
The version on NPM does not support `@container` queries. There was a [PR][0]
proposed that added this, but that has since been closed. However, the
PR did actually resolve the issue so I forked it into
lookback/postcss-csso and pointed the dependency directly to the git
repo here.

0: lahmatiy/postcss-csso#28
lookback-hugotunius added a commit to lookback/lookbook that referenced this pull request Jul 4, 2024
The version on NPM does not support `@container` queries. There was a [PR][0]
proposed that added this, but that has since been closed. However, the
PR did actually resolve the issue so I forked it into
lookback/postcss-csso and pointed the dependency directly to the git
repo here.

[0]: lahmatiy/postcss-csso#28
lookback-hugotunius added a commit to lookback/lookbook that referenced this pull request Jul 4, 2024
The version on NPM does not support `@container` queries. There was a [PR][0]
proposed that added this, but that has since been closed. However, the
PR did actually resolve the issue so I forked it into
lookback/postcss-csso and pointed the dependency directly to the git
repo here.

[0]: lahmatiy/postcss-csso#28
@wegry wegry reopened this Jul 4, 2024
@wegry
Copy link
Author

wegry commented Jul 4, 2024

@k0nserv I had been experimenting with container queries in my previous role. The role's browser support didn't allow container queries, so I punted on this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants