Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(RAIN-90851): Add permission for two glue APIs #84

Merged
merged 5 commits into from
Nov 15, 2023

Conversation

jjzhangjjzhang
Copy link
Contributor

@jjzhangjjzhang jjzhangjjzhang commented Nov 9, 2023

Summary

Based on https://lacework.atlassian.net/browse/RAIN-71778, We need to add resource coverage for aws glue ListWorkflows and BatchGetWorkflows.
This is one of the citi requirements

How did you test this change?

Without this PR, crawl in dev8, we see the error like below.

An error occurred (AccessDeniedException) when calling the ListWorkflows operation (reached max retries: 0): User: arn:aws:sts::647104928493:assumed-role/lw-iam-472ef824/LACEWORK-CFG-external is not authorized to perform: glue:ListWorkflows because no identity-based policy allows the glue:ListWorkflows action", service="glue", method_name="list_workflows"

With this PR and also terraform apply, the error is gone

Issue

@jjzhangjjzhang jjzhangjjzhang changed the title Add permission for two blue APIs feat(RAIN-90851): Add permission for two blue APIs Nov 9, 2023
@jjzhangjjzhang jjzhangjjzhang marked this pull request as ready for review November 9, 2023 22:57
@jjzhangjjzhang jjzhangjjzhang changed the title feat(RAIN-90851): Add permission for two blue APIs feat(RAIN-90851): Add permission for two glue APIs Nov 9, 2023
@jjzhangjjzhang jjzhangjjzhang merged commit 601e098 into main Nov 15, 2023
2 checks passed
@jjzhangjjzhang jjzhangjjzhang deleted the gluePermission branch November 15, 2023 21:19
@lacework-releng lacework-releng mentioned this pull request Jan 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants