Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: bump SAST to 0.0.46 #60

Merged
merged 1 commit into from
Jul 6, 2023
Merged

chore: bump SAST to 0.0.46 #60

merged 1 commit into from
Jul 6, 2023

Conversation

jeremydubreil
Copy link
Contributor

@jeremydubreil jeremydubreil commented Jun 30, 2023

The --classes option SAST which was previously accepting a directory or a JAR file has now been replaced by a more generic --classpath option which is intended to be the standard Java classpath containing all the classes including the dependencies or self-contained JAR or WAR files with nested JAR dependencies.

The main goal is to make the SAST API more generic and able to work in the same way with Mariana Trench and Infer.

This changes the public API of the action code so we will need to create a different release tag to migrate the place where this code is used progressively.

@jeremydubreil jeremydubreil marked this pull request as draft June 30, 2023 08:27
@jeremydubreil jeremydubreil force-pushed the bump-sast branch 3 times, most recently from 06241d6 to daa8072 Compare July 3, 2023 09:55
@jeremydubreil jeremydubreil marked this pull request as ready for review July 3, 2023 10:37
@edoardopirovano
Copy link
Contributor

Do we really need to make a new tag for just a renaming? Couldn't we temporarily accept both classes and classpath in the code while we update all usages to the latter?

@jeremydubreil
Copy link
Contributor Author

@edoardopirovano
Yes, we can do this. I realized that I messed up my local commit and this PR should not pass the test because I forgot to update one of the files.

@edoardopirovano
Copy link
Contributor

I think you need to thread through the new input here too:

@jeremydubreil
Copy link
Contributor Author

I think you need to thread through the new input here too:

Should I pass both classes and classpath here?

@edoardopirovano
Copy link
Contributor

Should I pass both classes and classpath here?

Yes please.

@@ -61,7 +61,7 @@ jobs:
exit 1
fi
export SAST_RESULTS=`jq '.runs | map (.results | length) | add' sast.sarif`
expectedSastResults=2
expectedSastResults=1
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually, 1 is the expected number of SAST finding we need to detect on the test project. I don't know why were the tests passing before.

@jeremydubreil jeremydubreil marked this pull request as ready for review July 6, 2023 09:03
@jeremydubreil jeremydubreil merged commit cc75c68 into main Jul 6, 2023
2 checks passed
@jeremydubreil jeremydubreil deleted the bump-sast branch July 6, 2023 10:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants