Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Take all_vote_count into account in client-side sorting #140

Merged
merged 1 commit into from
Mar 29, 2018

Conversation

JeffreyATW
Copy link
Collaborator

Related to #134. If two restaurants have the same amount of today’s votes, the one with the most historic votes will appear on top.

If two restaurants have the same amount of today’s votes, the one with the most historic votes will appear on top.
@JeffreyATW JeffreyATW requested a review from nyscherm March 28, 2018 23:34
},
4: {
id: 4,
name: 'Burger Bonanza',
votes: [7],
all_vote_count: 10
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small detail, missing a comma here

@nyscherm nyscherm merged commit 62e8c77 into develop Mar 29, 2018
@nyscherm nyscherm deleted the jeffrey/sort-all-votes branch March 29, 2018 19:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants