Add google analytics 4 support #74
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tgaff
commented
Sep 15, 2023
|
|
||
| w.loadJSDeferred('https://www.googletagmanager.com/gtag/js?id={{ site.google_analytics }}'); | ||
| }(window, document);</script> | ||
| {% endif %} |
There was a problem hiding this comment.
There's a combination of liquid/jekyll code wrapping JS here. The JS is by and large what Google suggests just with the necessary Jekyll/theme stuff merged in.
mjelks
approved these changes
Sep 15, 2023
| @@ -60,3 +60,6 @@ titles_from_headings: | |||
| # - languages/index.md | |||
| # - process/speclet_playbook.md | |||
| # - process/testing_strategy.md | |||
|
|
|||
|
|
|||
| google_analytics: G-2NX5YFW46E | |||
There was a problem hiding this comment.
ah, I see what's going on below. so do we want the value in the repo or 🤷
There was a problem hiding this comment.
Yep, for future reference this is not a secret. It'll show up many times in the network tab as part of URLs. It's just the way GA works. If someone else wants to steal it, they're welcome to enjoy their console.log'd wrong domain messages courtesy of GA.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The GA built into this theme is the old UA version which ceased processing data in July. This sets up GA4 instead.
I've submitted similar code to hydejack in PR330. Based on other issues/PRs on that repo its not likely to be merged soon. In this PR I've torn out most of the complexity that I'm unable to test (not having a pro license) and we don't use anyway.
A variation of this was tested on my fork.
Edit: GA indicates its received some pings in the last 24 hours so I think this is working.