-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding in Design Team Charter #103
Conversation
fix link in visualizing-product-initiatives.md
It works fine in GH markdown, but not in kramdown on publish.
changed LastPass to Bitwarden
Update securing_your_workspace.md
It actually works fine - on this page only and that could be a source of confusion.
rework documentation on links
also trying to close this branch. And any other branches I made. :p |
@traceykthompson In general this looks good and improves the language. I am confused though by why the branch appears to duplicate commits from further up in the tree. You can see evidence of that in the commit history - it should just show your change and also in the changes on index.md. If you check the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I was going to approve but noticed something very weird.
This looks like a backwards merge of master into your branch. It should be the other way around.
e.g.
traceykthompson wants to merge 10 commits into master from traceykthompson-patch-1.
I'll try to fix-up the branch and create a PR for you. Those commits shouldn't be showing here.
1. [.html file suffix](process/making-decisions.html) | ||
2. [File in the same directory](languages/sibling-document.md) | ||
3. [Page in a different directory using `/`](/other-dir/presentation.md) (only works on root level pages) | ||
4. [Bare URL](labzero.com) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
4. [Bare URL](labzero.com) | |
4. [Bare URL](labzero.com) or [http URL](http://labzero.com) |
Added to guide TOC as well