Use Enum classes for the channel value formats and post processing flags #87
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Keep those original variables in file for backwards compatibility but remove their comments and recommend to use the Enum classes instead
Also update the imports and for the examples to no longer use the aliased `resolve_stream()` function
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use Python's Enum class to group the channel value formats and post processing flags.
Doing this groups the two sets of variables into semantically meaningful classes and now the attributes within are commented in a way to show up in IntelliSense. By also grouping this way, the
cf_andproc_prefixes can be removed to aid in readability.Code changes:
resolve_stream()function and instead replace withresolve_byprop()where appropriate