Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(addon): add helm release install control variable #7

Merged
merged 1 commit into from
Dec 12, 2024

Conversation

jaygridley
Copy link
Member

Description

There might be cases installation via Helm might be done in 2 steps - 1st other resources, 2nd Helm release. This feature originates from one of our addons as community enhancement.

Type of change

  • A bug fix (PR prefix fix)
  • A new feature (PR prefix feat)
  • A code change that neither fixes a bug nor adds a feature (PR prefix refactor)
  • Adding missing tests or correcting existing tests (PR prefix test)
  • Changes that do not affect the meaning of the code like white-spaces, formatting, missing semi-colons, etc. (PR prefix style)
  • Changes to our CI configuration files and scripts (PR prefix ci)
  • Documentation only changes (PR prefix docs)

How Has This Been Tested?

@jaygridley jaygridley requested a review from Balsir December 11, 2024 10:41
@jaygridley jaygridley self-assigned this Dec 11, 2024
Copy link
Contributor

@Balsir Balsir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jaygridley jaygridley merged commit d91d2a7 into main Dec 12, 2024
5 checks passed
@jaygridley jaygridley deleted the feat/addon-helm-enabled-flag branch December 12, 2024 08:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants