Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(iam): Fix IAM permissions #5

Merged
merged 4 commits into from
Apr 18, 2024
Merged

fix(iam): Fix IAM permissions #5

merged 4 commits into from
Apr 18, 2024

Conversation

Balsir
Copy link
Contributor

@Balsir Balsir commented Apr 18, 2024

Description

Fixes bug in IAM permissions that prevents deletion of EBS volumes.
https://stackoverflow.com/questions/73576780/aws-ebs-csi-driver-could-not-delete-volume-id-vol-xxx-deletedisk-could-not-d
kubernetes-sigs/aws-ebs-csi-driver@b1d476c

Type of change

  • A bug fix (PR prefix fix)
  • A new feature (PR prefix feat)
  • A code change that neither fixes a bug nor adds a feature (PR prefix refactor)
  • Adding missing tests or correcting existing tests (PR prefix test)
  • Changes that do not affect the meaning of the code like white-spaces, formatting, missing semi-colons, etc. (PR prefix style)
  • Changes to our CI configuration files and scripts (PR prefix ci)
  • Documentation only changes (PR prefix docs)

How Has This Been Tested?

@Balsir Balsir requested a review from dojci April 18, 2024 09:32
@Balsir Balsir self-assigned this Apr 18, 2024
@Balsir Balsir added the bug Something isn't working label Apr 18, 2024
iam.tf Show resolved Hide resolved
Copy link
Member

@dojci dojci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Balsir Balsir merged commit a47f634 into main Apr 18, 2024
5 checks passed
@Balsir Balsir deleted the fix/fix-iam-permissions branch April 18, 2024 13:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants