feat(backup): Add vault lock configuration #4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jaygridley
requested changes
Dec 19, 2024
| @@ -127,3 +135,11 @@ resource "aws_backup_vault_policy" "target" { | |||
| backup_vault_name = aws_backup_vault.target[0].name | |||
| policy = data.aws_iam_policy_document.target_vault[0].json | |||
| } | |||
|
|
|||
| resource "aws_backup_vault_lock_configuration" "target" { | |||
| count = var.enabled && var.is_cross_account_backup_enabled && var.vault_lock_enabled ? 1 : 0 | |||
There was a problem hiding this comment.
Would it make sense to have vault lock enabled only in the target account, but not in the source one? If so, can we add support for this setup?
There was a problem hiding this comment.
Personally, I would only have this module handle just one vault, and have source/target replication handled in the integration via 2 module calls and extra params.
I haven't found any evidence as to how Backup behaves if lock is enabled only on one side, but yeah, we can split the config.
Co-authored-by: Martin Odstrčilík <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add vault lock configuration
Type of change
fix)feat)refactor)test)style)ci)docs)How Has This Been Tested?