Develop cleanup 2 #82
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tomers
reviewed
Sep 29, 2024
| class LabelMarginsPx(NamedTuple): | ||
| horizontal: int | ||
| vertical: int | ||
|
|
There was a problem hiding this comment.
According to Python docs, NamedTuple type hint is a "Typed version of collections.namedtuple()". See https://docs.python.org/3/library/typing.html#typing.NamedTuple
Don't you prefer to use collections.namedtuple, instead of a regular Python class?
There was a problem hiding this comment.
Good question. Some benefits:
- Types. With
collections.namedtupleyou just have names, without the types, so you wouldn't get type checking. - Syntax. This behaves and looks like a normal Python class, but the init and string representation are managed for you. This also makes it easy to switch out with similar data containers, like
pydantic.BaseModelin case you need input validation.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following up from #66