[pull] master from rclone:master #238
Open
+450,824
−140,873
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![pull[bot]](https://avatars.githubusercontent.com/in/12910?s=60&v=4){kind=small}
Before this change we used the repo with an initial uppercase `U`. However it is now canonically spelled with a lower case `u`. This package is too old to have a go.mod but the README clearly states the desired capitalization. In unknwon/goconfig@4b0d4b8 the recommended capitalization was changed to lower case. Co-authored-by: John Oxley <[email protected]>
Before this change, bisync proactively converted modtime precision when greater than what the destination backend supported. This dates back to a time before bisync considered the modifyWindow for same-side comparisons. Back then, it was problematic to save a listing with 12:54:49.7 for a backend that can't handle that precision, as on the next run the backend would report the time as 12:54:50 and bisync would think the file had changed. So the truncation was a workaround to anticipate this and proactively record the time with the precision we expect to receive next time. However, this caused problems for backends (such as dropbox) that round instead of truncating as bisync expected. After this change, bisync preserves the original precision in the listing (without conversion), even when greater than what the backend supports, to avoid rounding error. On the next run, bisync will compare it to the rounded time reported by the backend, and if it's within the modifyWindow, it will treat them as equivalent.
…version for windows Starting with go1.22 the standard os.MkdirAll has improved its handling of volume names, and as part of that it now stops recursing into parent directory if it is a volume name (see: golang/go@cd589c8). This is similar to what was our main change and reason for creating a custom version. When building with go1.22 or newer we can therefore stop using our custom version, with the advantage that we automatically get current and future relevant improvements from golang. To support building with go1.21 the existing custom version is still kept, and therefore also our wrapper function file.MkdirAll - but it now just calls os.MkdirAll with go1.22 or newer on Windows. See #5401, #6420 and acf1e2d for details about the creation of our custom version of MkdirAll.
Signed-off-by: crystalstall <[email protected]>
Before this fix, rclone queried the uploaded object to find its size and modtime after upload as the API did not return these items. Zoho have subsequently modified the API to return these items so rclone uses them to avoid an API call. This should help with rclone being throttled by Zoho. See: https://forum.rclone.org/t/second-followup-on-the-older-topic-rclone-invokes-more-number-of-workdrive-s-files-listing-api-calls-which-exceeds-the-throttling-limit/45697/20
Before this change all exports were exported as root and the --uid and --gid flags of the VFS were ignored. This fixes the issue by exporting the UID and GID correctly which default to the current user and group unless set explicitly.
…s flag Before this change the --links flag when using the VFS override the --links flag for the local backend which meant the local backend needed explicit config to use links. This fixes the problem by making the --links flag global and adding a new --local-links flag and --vfs-links flags to control the features individually if required.
Fix in extreme cases, when the job is executing finish(), the listener added by calling OnFinish() will never be executed. This change should not cause compatibility issues, as consumers should not make assumptions about whether listeners will be run in a new goroutine
… rclone authorize
This page started talking about what commands you can send, without explaining how to actually send them. Fixes #8252.
According to the SDK docs > FileRequestIntent is required when using TokenCredential for > authentication. Acceptable value is backup. This sets the correct option in the SDK. It does it for all types of authentication but the SDK seems clever enough not to supply it when it isn't needed. This fixes the error > MissingRequiredHeader An HTTP header that's mandatory for this > request is not specified. x-ms-file-request-intent Fixes #8241
An attacker can craft an input to the Parse functions that would be processed non-linearly with respect to its length, resulting in extremely slow parsing. This could cause a denial of service. This only affects users running rclone servers exposed to untrusted networks. See: https://pkg.go.dev/vuln/GO-2024-3333 See: GHSA-w32m-9786-jp63
This had two problems 1. It was using a single digit for day of month 2. It is supposed to be in UTC Fixes #8277
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot]
Can you help keep this open source service alive? 💖 Please sponsor : )