[pull] main from microsoft:main #228
Merged
+47
−16
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![pull[bot]](https://avatars.githubusercontent.com/in/12910?s=60&v=4){kind=small}
I wrote a big comment next to the changes I made. This is a redo of #17961 which had various issues. Closes #17916 Closes #18070 ## Validation Steps Performed * Pressing Enter within the input line doesn't crash ✅ * Type "Cour" and pick Courier New, press Save = Saved ✅ * Pick any other font from the dropdown, press Save = Saved ✅ * Picking an option dismisses focus but not to the tab row ✅ * The first time after launching the SUI, when the setting is still unmodified, when you focus the box and pick an option, it'll unfocus the box ✅ * When the setting is unmodified, and you pick the default (Cascadia Mono), it'll still unfocus the box ✅
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot]
Can you help keep this open source service alive? 💖 Please sponsor : )