Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[pull] main from microsoft:main #179

Merged
merged 2 commits into from
May 16, 2024
Merged

[pull] main from microsoft:main #179

merged 2 commits into from
May 16, 2024

Commits on May 15, 2024

  1. Fix persistence of handoff'd tabs (#17268) 

    As it turns out, for handoff'd connections `Initialize` isn't called
and this meant the `_sessionId` was always null.
After this PR we still don't have a `_profileGuid` but that's probably
not a critical issue, since that's an inherent flaw with handoff.
It can only be solved in a robust manner if WT gets launched before the
console app is launched, but it's unlikely for that to ever happen.

## Validation Steps Performed
* Launch
* Register that version of WT as the default
* Close all tabs (Ctrl+Shift+W)
* `persistedWindowLayouts` is empty ✅
* Launch cmd/pwsh via handoff
* You get 1 window ✅
* Close the window (= press the X button)
* Launch
* You get 2 windows ✅
    @lhecker
    lhecker authored May 15, 2024
    Configuration menu
    Copy the full SHA
    9054c81 View commit details
    Browse the repository at this point in the history

  2. Fix lock warning during ReturnResponse (#17266) 

    As reported here:
#16224 (comment)

The underlying `WriteFile` call may block indefinitely and
we shouldn't hold the terminal lock during that period.
    @lhecker
    lhecker authored May 15, 2024
    Configuration menu
    Copy the full SHA
    183a895 View commit details
    Browse the repository at this point in the history