[pull] dev from opf:dev #59
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![pull[bot]](https://avatars.githubusercontent.com/in/12910?s=60&v=4){kind=small}
This is already implemented in the Principal factory
Permission Rework [3/x]: Easier membership setup for factories
Use entity_class instead of hard coded class name in UserPermissibleService
As per the docs: "If pattern is a string, only the first occurrence will be replaced."
…closed-work-package-and-duration [50485] No spacing between "Undisclosed work package" and duration
The following test could fail if run alone:
rspec './spec/requests/api/v3/attachments/work_packages_export_spec.rb[1:1:2:2]'
Because `WorkPackages::Export` is not loaded yet, and would not have
been added to `Redmine::Acts::Attachable.attachables`.
…-attachment-prepare 29203 Fix missing permission on attachment prepare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot]
Can you help keep this open source service alive? 💖 Please sponsor : )