[pull] dev from opf:dev #58
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![pull[bot]](https://avatars.githubusercontent.com/in/12910?s=60&v=4){kind=small}
This allows adding attachments even without Edit WP permission.
also add init helper to wait for db
Since the application is already using the default this change should not really constitute a change
The opce-select-decoration is now rendered on page load, which results in the project-autocompleter being incorrectly bootstrapped dynamically and the instance losing all inputs. By ensuring we only use custom elements instead of boostrapping, we can avoid this error. In the short term, I want to remove all embeddable bootstrapped components and turn them into custom elements.
The purpose of `@component_wrapper_used` in this scenario is to check if the component that is to be inserted into the target has used a `component_wrapper` in its template rendering. This both: * Fixes the issue where this will always raise an error as the target component is not being rendered (and doesn't need to be). * Ensures that there is a unique ID set at the top-most level of the turbo stream response and turbo can de-duplicate any existing components that match the current ID of the component before appending/prepending.
Bumps [aws-sdk-core](https://github.com/aws/aws-sdk-ruby) from 3.185.0 to 3.185.1. - [Release notes](https://github.com/aws/aws-sdk-ruby/releases) - [Changelog](https://github.com/aws/aws-sdk-ruby/blob/version-3/gems/aws-sdk-core/CHANGELOG.md) - [Commits](https://github.com/aws/aws-sdk-ruby/commits) --- updated-dependencies: - dependency-name: aws-sdk-core dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]>
Bumps [erblint-github](https://github.com/github/erblint-github) from 0.4.1 to 0.5.0. - [Release notes](https://github.com/github/erblint-github/releases) - [Commits](github/erblint-github@v0.4.1...v0.5.0) --- updated-dependencies: - dependency-name: erblint-github dependency-type: direct:development update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]>
…xtcloud-project-folders-does-not-recreate-file-links-to-folders [#50295] copying projects with nextcloud project folders does not recreate file links to folders
- refactored nextcloud upload service to storage upload service using different strategies for each provider type - fixed type urn in storage representer - amended storage component to seed correct strategy
…13897) * Lint: Fix match_array Rubocop offenses * Performance: Improve performance of `update_ancestors_service_spec` By using some of the [profilers provided by test-prof](https://test-prof.evilmartians.io/#/profilers/factory_prof), I found we're spending a massive 81% of the total time in factories for this spec file. By leveraging the `shared_let` strategy and preventing factory cascades, we can chop this down significantly to something more reasonable. As demonstrated below, the average execution time of the spec file was reduced from **~23 seconds** down to **~6.9 seconds** . Average time spent in factories went down from 81.2% to 48.01%. Most of this time is still spent in work package creation but this is just because the spec requires a lot of work packages being created. Despite this, I still believe the changes performed are quite a significant bump to the spec's performance! 🏎️ ``` Finished in 23.04 seconds (files took 8.61 seconds to load) 65 examples, 0 failures Randomized with seed 48285 [TEST PROF INFO] Time spent in factories: 00:20.385 (81.2% of total time) [TEST PROF INFO] Factories usage Total: 1370 Total top-level: 362 Total time: 00:20.385 (out of 00:29.258) Total uniq factories: 7 total top-level total time time per call top-level time name 286 65 2.9315s 0.0102s 0.6740s user 286 0 0.4635s 0.0016s 0.0000s notification_setting 221 221 19.4693s 0.0881s 19.4693s work_package 221 0 0.6336s 0.0029s 0.0000s priority 221 0 12.0981s 0.0547s 0.0000s project_with_types 115 56 0.3583s 0.0031s 0.1911s status 20 20 0.0507s 0.0025s 0.0507s closed_status ``` ``` Finished in 6.86 seconds (files took 9 seconds to load) 65 examples, 0 failures Randomized with seed 43677 [TEST PROF INFO] Time spent in factories: 00:04.260 (48.01% of total time) [TEST PROF INFO] Factories usage Total: 254 Total top-level: 227 Total time: 00:04.260 (out of 00:13.042) Total uniq factories: 7 total top-level total time time per call top-level time name 221 221 3.9714s 0.0180s 3.9714s work_package 7 2 0.1462s 0.0209s 0.1058s user 7 0 0.0201s 0.0029s 0.0000s notification_setting 6 1 0.3817s 0.0636s 0.1561s project_with_types 6 1 0.0230s 0.0038s 0.0114s priority 6 1 0.0243s 0.0040s 0.0132s status 1 1 0.0027s 0.0027s 0.0027s closed_status ```
Bumps [rubocop](https://github.com/rubocop/rubocop) from 1.56.4 to 1.57.0. - [Release notes](https://github.com/rubocop/rubocop/releases) - [Changelog](https://github.com/rubocop/rubocop/blob/master/CHANGELOG.md) - [Commits](rubocop/rubocop@v1.56.4...v1.57.0) --- updated-dependencies: - dependency-name: rubocop dependency-type: direct:development update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]>
Bumps [turbo-rails](https://github.com/hotwired/turbo-rails) from 1.4.0 to 1.5.0. - [Release notes](https://github.com/hotwired/turbo-rails/releases) - [Commits](hotwired/turbo-rails@v1.4.0...v1.5.0) --- updated-dependencies: - dependency-name: turbo-rails dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]>
Bumps [responders](https://github.com/heartcombo/responders) from 3.1.0 to 3.1.1. - [Release notes](https://github.com/heartcombo/responders/releases) - [Changelog](https://github.com/heartcombo/responders/blob/main/CHANGELOG.md) - [Commits](heartcombo/responders@v3.1.0...v3.1.1) --- updated-dependencies: - dependency-name: responders dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]>
Bumps the angular group in /frontend with 13 updates: | Package | From | To | | --- | --- | --- | | [@angular/animations](https://github.com/angular/angular/tree/HEAD/packages/animations) | `16.2.8` | `16.2.9` | | [@angular/cdk](https://github.com/angular/components) | `16.2.7` | `16.2.8` | | [@angular/cli](https://github.com/angular/angular-cli) | `16.2.5` | `16.2.6` | | [@angular/common](https://github.com/angular/angular/tree/HEAD/packages/common) | `16.2.8` | `16.2.9` | | [@angular/compiler](https://github.com/angular/angular/tree/HEAD/packages/compiler) | `16.2.8` | `16.2.9` | | [@angular/compiler-cli](https://github.com/angular/angular/tree/HEAD/packages/compiler-cli) | `16.2.8` | `16.2.9` | | [@angular/core](https://github.com/angular/angular/tree/HEAD/packages/core) | `16.2.8` | `16.2.9` | | [@angular/elements](https://github.com/angular/angular/tree/HEAD/packages/elements) | `16.2.8` | `16.2.9` | | [@angular/forms](https://github.com/angular/angular/tree/HEAD/packages/forms) | `16.2.8` | `16.2.9` | | [@angular/platform-browser](https://github.com/angular/angular/tree/HEAD/packages/platform-browser) | `16.2.8` | `16.2.9` | | [@angular/platform-browser-dynamic](https://github.com/angular/angular/tree/HEAD/packages/platform-browser-dynamic) | `16.2.8` | `16.2.9` | | [@angular/router](https://github.com/angular/angular/tree/HEAD/packages/router) | `16.2.8` | `16.2.9` | | [@angular-devkit/build-angular](https://github.com/angular/angular-cli) | `16.2.5` | `16.2.6` | Updates `@angular/animations` from 16.2.8 to 16.2.9 - [Release notes](https://github.com/angular/angular/releases) - [Changelog](https://github.com/angular/angular/blob/main/CHANGELOG.md) - [Commits](https://github.com/angular/angular/commits/16.2.9/packages/animations) Updates `@angular/cdk` from 16.2.7 to 16.2.8 - [Release notes](https://github.com/angular/components/releases) - [Changelog](https://github.com/angular/components/blob/main/CHANGELOG.md) - [Commits](angular/components@16.2.7...16.2.8) Updates `@angular/cli` from 16.2.5 to 16.2.6 - [Release notes](https://github.com/angular/angular-cli/releases) - [Changelog](https://github.com/angular/angular-cli/blob/main/CHANGELOG.md) - [Commits](angular/angular-cli@16.2.5...16.2.6) Updates `@angular/common` from 16.2.8 to 16.2.9 - [Release notes](https://github.com/angular/angular/releases) - [Changelog](https://github.com/angular/angular/blob/main/CHANGELOG.md) - [Commits](https://github.com/angular/angular/commits/16.2.9/packages/common) Updates `@angular/compiler` from 16.2.8 to 16.2.9 - [Release notes](https://github.com/angular/angular/releases) - [Changelog](https://github.com/angular/angular/blob/main/CHANGELOG.md) - [Commits](https://github.com/angular/angular/commits/16.2.9/packages/compiler) Updates `@angular/compiler-cli` from 16.2.8 to 16.2.9 - [Release notes](https://github.com/angular/angular/releases) - [Changelog](https://github.com/angular/angular/blob/main/CHANGELOG.md) - [Commits](https://github.com/angular/angular/commits/16.2.9/packages/compiler-cli) Updates `@angular/core` from 16.2.8 to 16.2.9 - [Release notes](https://github.com/angular/angular/releases) - [Changelog](https://github.com/angular/angular/blob/main/CHANGELOG.md) - [Commits](https://github.com/angular/angular/commits/16.2.9/packages/core) Updates `@angular/elements` from 16.2.8 to 16.2.9 - [Release notes](https://github.com/angular/angular/releases) - [Changelog](https://github.com/angular/angular/blob/main/CHANGELOG.md) - [Commits](https://github.com/angular/angular/commits/16.2.9/packages/elements) Updates `@angular/forms` from 16.2.8 to 16.2.9 - [Release notes](https://github.com/angular/angular/releases) - [Changelog](https://github.com/angular/angular/blob/main/CHANGELOG.md) - [Commits](https://github.com/angular/angular/commits/16.2.9/packages/forms) Updates `@angular/platform-browser` from 16.2.8 to 16.2.9 - [Release notes](https://github.com/angular/angular/releases) - [Changelog](https://github.com/angular/angular/blob/main/CHANGELOG.md) - [Commits](https://github.com/angular/angular/commits/16.2.9/packages/platform-browser) Updates `@angular/platform-browser-dynamic` from 16.2.8 to 16.2.9 - [Release notes](https://github.com/angular/angular/releases) - [Changelog](https://github.com/angular/angular/blob/main/CHANGELOG.md) - [Commits](https://github.com/angular/angular/commits/16.2.9/packages/platform-browser-dynamic) Updates `@angular/router` from 16.2.8 to 16.2.9 - [Release notes](https://github.com/angular/angular/releases) - [Changelog](https://github.com/angular/angular/blob/main/CHANGELOG.md) - [Commits](https://github.com/angular/angular/commits/16.2.9/packages/router) Updates `@angular-devkit/build-angular` from 16.2.5 to 16.2.6 - [Release notes](https://github.com/angular/angular-cli/releases) - [Changelog](https://github.com/angular/angular-cli/blob/main/CHANGELOG.md) - [Commits](angular/angular-cli@16.2.5...16.2.6) --- updated-dependencies: - dependency-name: "@angular/animations" dependency-type: direct:production update-type: version-update:semver-patch dependency-group: angular - dependency-name: "@angular/cdk" dependency-type: direct:production update-type: version-update:semver-patch dependency-group: angular - dependency-name: "@angular/cli" dependency-type: direct:production update-type: version-update:semver-patch dependency-group: angular - dependency-name: "@angular/common" dependency-type: direct:production update-type: version-update:semver-patch dependency-group: angular - dependency-name: "@angular/compiler" dependency-type: direct:production update-type: version-update:semver-patch dependency-group: angular - dependency-name: "@angular/compiler-cli" dependency-type: direct:production update-type: version-update:semver-patch dependency-group: angular - dependency-name: "@angular/core" dependency-type: direct:production update-type: version-update:semver-patch dependency-group: angular - dependency-name: "@angular/elements" dependency-type: direct:production update-type: version-update:semver-patch dependency-group: angular - dependency-name: "@angular/forms" dependency-type: direct:production update-type: version-update:semver-patch dependency-group: angular - dependency-name: "@angular/platform-browser" dependency-type: direct:production update-type: version-update:semver-patch dependency-group: angular - dependency-name: "@angular/platform-browser-dynamic" dependency-type: direct:production update-type: version-update:semver-patch dependency-group: angular - dependency-name: "@angular/router" dependency-type: direct:production update-type: version-update:semver-patch dependency-group: angular - dependency-name: "@angular-devkit/build-angular" dependency-type: direct:development update-type: version-update:semver-patch dependency-group: angular ... Signed-off-by: dependabot[bot] <[email protected]>
Bumps [sass](https://github.com/sass/dart-sass) from 1.69.1 to 1.69.3. - [Release notes](https://github.com/sass/dart-sass/releases) - [Changelog](https://github.com/sass/dart-sass/blob/main/CHANGELOG.md) - [Commits](sass/dart-sass@1.69.1...1.69.3) --- updated-dependencies: - dependency-name: sass dependency-type: direct:development update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]>
Extract view logic into separate files
…3.1.1 Bump responders from 3.1.0 to 3.1.1
Bump rubocop from 1.56.4 to 1.57.0
…ev/sass-1.69.3 Bump sass from 1.69.1 to 1.69.3 in /frontend
…ev/angular-3309b37a20 Bump the angular group in /frontend with 13 updates
…-1.5.0 Bump turbo-rails from 1.4.0 to 1.5.0
Bumps [@babel/core](https://github.com/babel/babel/tree/HEAD/packages/babel-core) from 7.23.0 to 7.23.2. - [Release notes](https://github.com/babel/babel/releases) - [Changelog](https://github.com/babel/babel/blob/main/CHANGELOG.md) - [Commits](https://github.com/babel/babel/commits/@babel/[email protected]/packages/babel-core) --- updated-dependencies: - dependency-name: "@babel/core" dependency-type: direct:development update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]>
Chore/prepare for rails 7.1
…ev/babel/core-7.23.2 Bump @babel/core from 7.23.0 to 7.23.2 in /frontend
Permission Rework [2/x]: Extract all permission methods from `User` model and implement a new Permission Query Service
PR #13897 did a great job at improving the performance of running `work_packages/update_ancestors_service_spec` spec by making it 70% faster. With some additional `shared_let`, it's possible to have less work packages created and gain a little 20% more. Before: ``` Finished in 4.55 seconds (files took 8.14 seconds to load) 65 examples, 0 failures [TEST PROF INFO] Time spent in factories: 00:02.833 (39.19% of total time) [TEST PROF INFO] Factories usage Total: 254 Total top-level: 227 Total time: 00:02.833 (out of 00:10.861) Total uniq factories: 7 total top-level total time time per call top-level time name 221 221 2.6216s 0.0119s 2.6216s work_package 7 2 0.1100s 0.0157s 0.0777s user 7 0 0.0167s 0.0024s 0.0000s notification_setting 6 1 0.2549s 0.0425s 0.1045s project_with_types 6 1 0.0245s 0.0041s 0.0130s priority 6 1 0.0244s 0.0041s 0.0142s status 1 1 0.0024s 0.0024s 0.0024s closed_status ``` After: ``` Finished in 3.59 seconds (files took 8.25 seconds to load) 65 examples, 0 failures [TEST PROF INFO] Time spent in factories: 00:01.857 (29.59% of total time) [TEST PROF INFO] Factories usage Total: 131 Total top-level: 129 Total time: 00:01.857 (out of 00:09.947) Total uniq factories: 7 total top-level total time time per call top-level time name 123 123 1.6649s 0.0135s 1.6649s work_package 2 2 0.0780s 0.0390s 0.0780s user 2 0 0.0112s 0.0056s 0.0000s notification_setting 1 1 0.0946s 0.0946s 0.0946s project_with_types 1 1 0.0084s 0.0084s 0.0084s priority 1 1 0.0096s 0.0096s 0.0096s status 1 1 0.0017s 0.0017s 0.0017s closed_status ```
Correctly save and handle boolean settings in OIDC administration, limit auth provider by default
Show only visible meetings
…-update-ancestors-service-spec-even-more Make 20% faster work_packages/update_ancestors_service_spec
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot]
Can you help keep this open source service alive? 💖 Please sponsor : )