[pull] dev from opf:dev #56
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![pull[bot]](https://avatars.githubusercontent.com/in/12910?s=60&v=4){kind=small}
Given I attempt to remove a component via a turbo stream, this resulted in a ``` "You need to wrap your component in a `component_wrapper` block in order to use the turbo-stream methods" ``` error. This is due to the component template not being rendered and the `@component_wrapped_used` instance variable not being set (because the `component_wrapper` invocation in the component template is never called. The proposed fix for this is to render JUST the `component_wrapper` (without its block content) in order to get the dom id that needs removal and turbo streams is able to do its magic. This is achieved by providing a `@wrapper_only` flag so when the `component_wrapper` method is called within the component's template, only the wrapper tag is rendered, making it enough to perform a successful turbo stream removal of the component by handling this case with the short circuit. We don't really care in this case about rendering the entire component given all we care about is that outer tag.
The variable assignment was removed in 80192f6
remove unnecessary variable reset
…r-turbo-stream-response Fix `:remove` action for component turbo stream responses
pull bot
pushed a commit
that referenced
this pull request
Mar 8, 2024
Add support for global push events using system hook
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot]
Can you help keep this open source service alive? 💖 Please sponsor : )