[pull] dev from opf:dev #46
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![pull[bot]](https://avatars.githubusercontent.com/in/12910?s=60&v=4){kind=small}
- https://community.openproject.org/wp/49760 - ability to create onedrive storages - separated create and update contracts - amended view files - added locale strings - added stimulus controller for reactive forms - splitted new oauth client form into partials
- fixed StoragesControllerSpec - fixed storage edit page
- fixed file link SetAttributeServiceSpec - changed contract structure
- SetAttributesService spec for storages and file links - fixed storages controller - usage in storage update service spec
- fixed wrong base class for OneDriveContract - replaced contract resolvement with ioc container - fixed storage configuration check for onedrive - replaced short provider name to deliver snakecase instead of lowercase - made client secret for one drive storages mandatory
* Executes: `./bin/rails g model WorkPackageRole --skip-migrations --parent Role` * Tailors Factory and Model Spec
In order to more easily accomodate adding a seeder for `WorkPackageRole`s, splitting the catch-all `RoleSeeder` into a seeder per type would help facilitate and simplify how we grok through role seeding. The translation file structure was also modified to more easily group the different role types that are to be created whenever we start adding more role types to be seeded. The structure is now: ```yaml <<role_type>>s: # role_data ```
Creates the `WorkPackageRoleSeeder` class in charge of seeding the default roles of the `WorkPackageRole` type. Seeder specs added to assert the expected behavior.
Seeds the 3 default `WorkPackageRole`s with the set of permissions present on `config/initializers/permissions.rb` that apply.
Throughout some specs, we already set up users with a `copy_work_packages` permission. This led me to believe that at some point, there was the intent to split `move_work_packages` up to have a more fine-grained control between the two. Now, we would need the `copy_work_packages` permission for Work Package sharing, instead of the `move_work_packages` permission so we don't have a permission escalation concern and can manually assert against `copy_work_packages`. * Adds permission definition to initializer file * Creates migration to add the permission to those roles which already have the broader `move_work_packages` * Adds `copy_work_packages` to the `work_package_roles` seed data to populate the new default work package roles. * Add translation for permission.
* Replace usage of `match_array` with `contain_exactly`. * Use `subject` construct instead of `let`. * Reword contexts for verbosity and clarity.
* Clarifies intent and behavior of the module. * Addresses some Rubocop warnings.
Reads a bit better to me :)
Allows defining what role types a permission is assignable to. This provides a more flexible infrastructure than `global: true` or `global: false` now that we're moving on to have more than two role types.
* Fixes: ``` RuboCop: Use anonymous keyword arguments forwarding (`**`). [Style/ArgumentsForwarding] ```
* Includes `work_package`, `project` and `global` permissible_on definitions.
… core initializer * Includes `work_package`, `project` and `global` permissible_on definitions.
* Includes `work_package`, `project` and `global` permissible_on definitions.
* Includes `work_package`, `project` and `global` permissible_on definitions.
…alizer * Includes `work_package`, `project` and `global` permissible_on definitions.
* Includes `work_package`, `project` and `global` permissible_on definitions.
Co-authored-by: Kabiru Mwenja <[email protected]>
Add missing translations for public permissions
Remove debug statement in the middle of the case statement of RDM Mailhandler
…rs-with-active-nextcloud-storage-hosts
…ame-ancestors-with-active-nextcloud-storage-hosts [#49872] Extend CSP frame-ancestors with active nextcloud storage hosts
No longer will the non member role`s capabilities be signaled to be had by users having at least one role in the project. This is in sync with how the actual permission checks handle the permissions.
Fix/bump gems
…n_signaling Fix/incorrect non member permission signaling
…-concern [chore] removed configuration check concern
…endent-specs Apply skip metadata to `svnadmin`-dependent specs
…tem-test-setup Remove unused `system_test.rb` configuration file
* Uses `@mapped_permissions` as the source of permissions since `.permissions` only includes permissions that are currently enabled and we don't want to leave any out. * Raises a helpful error message for the developer running the spec.
Thanks Rubymine :)
* This should aid just a bit in the key lookup.
…-permission-translations Add unit test to ensure every permission has an english translation
…permission-translations Remove duplicate permission translations
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot]
Can you help keep this open source service alive? 💖 Please sponsor : )