[pull] dev from opf:dev #114
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![pull[bot]](https://avatars.githubusercontent.com/in/12910?s=60&v=4){kind=small}
…ity.openproject.org/work_packages/51702 [#51702] Update Nextcloud user guide with new features https://community.openproject.org/work_packages/51702
… active in project, shown in bulk edit https://community.openproject.org/work_packages/49619
…`click_link`. (convention:Capybara/ClickLinkOrButtonStyle)
…he split create form
…how/hide the "Gantt" option in the configuration modal of the WP module
…ule to show/hide the "Gantt" option in the configuration modal of the WP module" This reverts commit 116d1b8.
(moderate)" Reverts commit ff6e93d
…he card view full screen. For the WorkPackageModule the view selector was removed
…-user-guide-with-new-features
…re but a separate module
…ity.openproject.org/work_packages/51702 [#51702] Update Nextcloud user guide with new features https://community.openproject.org/work_packages/51702
Some contexts re-defined the `:project` memoized helper and hence lacked the enabled modules required for the spec to succeed.
There was no valid gantt wrapper within the work packages module table. To account for this, we assert the expected work packages against the WorkPackagesTable page object instead of the Timeline.
Since there was no view created for the query, the option was not populated in the sidebar, nor was it available in the autocompleter.
In local contexts, there can be failures due to different system timezones. Explicitly define the timezone preference to mitigate this. ``` expected to find visible css "[data-test-selector=\"storage-health-reason\"]" with text "Unauthorized: Outbound request not authorized since 11/28/2023 01:02 AM" but there were no matches. Also found "Unauthorized: Outbound request not authorized since 11/28/2023 02:02 AM", which matched the selector but not all filters. ```
See: spec/support/shared_let.rb Before: [TEST PROF INFO] Time spent in factories: 00:00.641 (1.44% of total time) After: [TEST PROF INFO] Time spent in factories: 00:00.225 (0.85% of total time)
- https://community.openproject.org/work_packages/52181 - fixed error handling of httpx responses - added unit test
Bump lefthook from 1.5.7 to 1.6.0
…cessible_selectors-679abc4 Bump capybara_accessible_selectors from `bbf8916` to `679abc4`
Work package shared with column
…-accessibility-for-the-new-and-edit-(primer)-file-storage-pages Accessibility/51021 test for basic accessibility for the new and edit (primer) file storage pages
…lbar-for-gantt-and-work-packages [51287] Different toolbar for Gantt and Work Packages
Co-authored-by: Eric Schubert <[email protected]>
Co-authored-by: Eric Schubert <[email protected]>
Fix Failing tests: Update `HTTPX` mocks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot]
Can you help keep this open source service alive? 💖 Please sponsor : )