[pull] master from neovim:master #4
Open
+138,036
−117,228
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![pull[bot]](https://avatars.githubusercontent.com/in/12910?s=60&v=4){kind=small}
Problem: macos-12 GH runners are deprecated and will be removed soon. Solution: use macos-13 runners instead.
ci: bump Intel macOS runners to 13
…ll (#30859) vim-patch:8.2.4744: a terminal window can't use the bell vim-patch:8.2.4745: using wrong flag for using bell in the terminal BREAKING CHANGE: Bells from :terminal are now silent by default, unless 'belloff' option doesn't contain "term" or "all".
…ugh (#30870) Problem: tests: Test_set_values() is not comprehensive enough Solution: Add a lot more test cases (Milly) closes: vim/vim#15892 vim/vim@cc15bbc Co-authored-by: Milly <[email protected]>
) Problem: tests: tests may fail on Windows environment Solution: use shellcmdflag=/D to skip executing autorun from the registry (Milly) closes: vim/vim#15900 vim/vim@4f5681d Cherry-pick Test_cursorhold_insert_with_timer_interrupt() change from patch 8.2.1836. Co-authored-by: Milly <[email protected]>
Problem: Cannot allow mouse interaction for non-focusable float window. Solution: Add a "mouse" field to float window config.
Problem: - `vim.highlight` module does not follow `:help dev-name-common`, which documents the name for "highlight" as "hl". - Shorter names are usually preferred. Solution: Rename `vim.highlight` to `vim.hl`. This is not a breaking change until 2.0 (or maybe never).
Problem: When exiting, processed events may still use memfiles after
they are closed.
Solution: Close memfiles after processing events.
Problem: 'vim.rpcrequest and vim.rpcnotify' is flaky on Windows. Solution: retry it.
Problem: `vim.validate()` takes two forms when it only needs one. Solution: - Teach the fast form all the features of the spec form. - Deprecate the spec form. - General optimizations for both forms. - Add a `message` argument which can be used alongside or in place of the `optional` argument.
Problem: testing of options can be further improved
Solution: split the generated option test into test_options_all.vim,
add more test cases, save and restore values, fix use-after-free
closes: vim/vim#15894
vim/vim@6eca04e
Co-authored-by: Milly <[email protected]>
Problem: too many strlen() calls in cmdhist.c
Solution: refactor code and remove strlen() calls
(John Marriott)
closes: vim/vim#15888
vim/vim@8df07d0
Co-authored-by: John Marriott <[email protected]>
Problem: filetype: Vivado memory info file are not recognized
Solution: detect '*.mmi' memory info file as xml filetype
(Wu, Zhenyu)
References: https://docs.amd.com/r/en-US/ug1580-updatemem/MMI-File-Syntax
closes: vim/vim#15906
vim/vim@0887e62
Co-authored-by: Wu, Zhenyu <[email protected]>
Problem: filetype: libtool files are not recognized
Solution: detect '*.{lo,la,lai}' as sh filetype
(Wu, Zhenyu)
closes: vim/vim#15751
vim/vim@bfe568d
Co-authored-by: Wu, Zhenyu <[email protected]>
closes: vim/vim#15897 vim/vim@421ed14 Co-authored-by: Luca Saccarola <[email protected]>
This brings the included Racket runtime files to commit c41bc5a (indent for[*]/lists with accumulator clause correctly, 2024-11-12) of https://github.com/benknoble/vim-racket. Note that not all files from that repository are included. closes: vim/vim#16046 vim/vim@8e013b1 Co-authored-by: D. Ben Knoble <[email protected]>
…lugin @Konfekt suggested adding this [1]; I confirmed that both source repositories have permissive licenses [2], [3] that permit copying the code (at least where the compiler scripts are concerned). [1]: benknoble/Dotfiles@570b100 [2]: https://github.com/JalaiAmitahl/maven-compiler.vim [3]: mikelue/vim-maven-plugin#13 closes: vim/vim#16041 vim/vim@c4208da Co-authored-by: D. Ben Knoble <[email protected]>
Before calling "attach" a screen object is just a dummy container for (row, col) values whose purpose is to be sent as part of the "attach" function call anyway. Just create the screen in an attached state directly. Keep the complete (row, col, options) config together. It is still completely valid to later detach and re-attach as needed, including to another session.
fix(tests): needing two calls to setup a screen is cringe
Problem: Lua callbacks for "msg_show" events with vim.ui_attach() are
executed when it is not safe.
Solution: Disallow non-fast API calls for "msg_show" event callbacks.
Automatically detach callback after excessive errors.
Make sure fast APIs do not modify Nvim state.
fix(messages)!: vim.ui_attach message callbacks are unsafe
Problem: message history is fixed to 200
Solution: Add the 'msghistory' option, increase the default
value to 500 (Shougo Matsushita)
closes: vim/vim#16048
vim/vim@4bd9b2b
Co-authored-by: Shougo Matsushita <[email protected]>
Co-authored-by: Milly <[email protected]>
Problem: setting 'cmdheight' may cause hit-enter-prompt and echo output
to be missing
Solution: Before cleaning the cmdline, check the need_wait_return flag
(nwounkn)
closes: vim/vim#13432
vim/vim@2e48567
Co-authored-by: nwounkn <[email protected]>
…1198 Problem: When there is a tree view opened by :InspectTree and the source buffer is open in multiple windows, closing one of the source windows will lead to the tree view being closed as well. Regression by #31181. Solution: Check how many source windows are open when trying to quit one. If there are more than one, keep the tree view(s) open. If the only source window is closed, also close the tree view(s). fix #31196
Explicitly installing Python 3.13 using (deprecated version of) `setup-python` looks to be no longer required for provider tests to pass.
Problem: filetype: org files are not recognized
Solution: detect '*.org' files as 'org' filetype,
include filetype and syntax plugin
(Luca Saccarola)
closes: vim/vim#16054
vim/vim@0684800
Co-authored-by: Luca Saccarola <[email protected]>
- do not enter dir in Netrw on opening - double quotes after start cause error on Windows See @chrisbra 's comments at [0] [0]: techntools/vim@ff82e7a#diff-39baf27d8f62071617bbef12f874cce31c0ebd02ec99e7b119474ca870c636a3R5279 vim/vim@460799d Co-authored-by: Konfekt <[email protected]>
…in indent script closes: vim/vim#16052 vim/vim@0acd3ab Co-authored-by: Lukas Zapletal <[email protected]>
… a comment fixes: vim/vim#16051 vim/vim@7c3b65e Co-authored-by: Christian Brabandt <[email protected]>
Problem: No longer able to show prompt messages with vim.ui_attach().
Solution: Do not execute callback in fast context for prompt message
kinds. These events must be safe to show the incoming message
so the event itself serves to indicate that the message
should be shown immediately.
Problem: filetype: LLVM IR files are not recognized
Solution: detect '*.ll' files either as lifelines or llvm filetype
(Wu, Zhenyu)
closes: vim/vim#15824
vim/vim@bc32bbd
N/A patch:
vim-patch:7e4b861: runtime(filetype): remove duplicated *.org file pattern
Co-authored-by: Wu, Zhenyu <[email protected]>
) Problem: too many strlen() calls in getchar.c Solution: refactor code and reduce strlen() calls (John Marriott) closes: vim/vim#16017 vim/vim@e7a1bbf Co-authored-by: John Marriott <[email protected]>
Problem: The way option scopes currently work is inflexible and does not allow for nested option scopes or easily finding the value of an option at any arbitrary scope without having to do long handwritten switch-case statements like in `get_varp()`. `.indir` is also confusing and redundant since option indices for each scope can be autogenerated. Solution: Expand option scopes in such a way that an option can support any amount of scopes using a set of scope flags, similarly to how it's already done for option types. Also make options contain information about its index at each scope it supports. This allows for massively simplifying `get_varp()` and `get_varp_scope()` in the future by just using a struct for options at each scope. This would be done by creating a table that stores the offset of an option's variable at a scope by using the option's index at that scope as a key. This PR also autogenerates enums for option indices at each scope to remove the need for `.indir` entirely, and also to allow easily iterating over options all options that support any scope. Ref: #29314
Problem: Floating windows with focusable set to false can reasonably be
expected to be UI elements but are listed in some outputs that
should contain only regular windows.
Solution: Hide unfocusable floating windows from the default tabline and
:tabs.
Problem: Documentation for "hl_group" in nvim_buf_set_extmark() is
unclear. "hl_group" in nvim_echo() does not accept
highlight group id.
Solution: Move documentation for highlight group name/id to first
mention of hl_group. Update nvim_echo() to accept highlight
group id.
Problem: Treesitter highlighter implements an on_bytes callback that
just re-marks a buffer range for redraw. The edit that
prompted the callback will already have done that.
Solution: Remove redundant on_bytes callback from the treesitter
highlighter module.
Fix regression from #31195
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot]
Can you help keep this open source service alive? 💖 Please sponsor : )